unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Glenn Morris <rgm@gnu.org>
Cc: 46625-done@debbugs.gnu.org
Subject: bug#46625: tramp-test33-environment-variables fails
Date: Fri, 19 Feb 2021 09:25:48 +0100	[thread overview]
Message-ID: <87blcg8nw3.fsf@gmx.de> (raw)
In-Reply-To: <njv9ap3ufz.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 18 Feb 2021 17:03:12 -0500")

Glenn Morris <rgm@gnu.org> writes:

Hi Glenn,

> tramp-test33-environment-variables fails on hydra.nixos since
> e5f50f32f76bab2607d77f0dc51cf81ec0c1e232.
>
> It seems to me that:
>
> (string-match-p (regexp-quote envvar) "printenv")
>
> isn't a robust way to test if ENVVAR is (not) set, because it can
> falsely match on $_=ENVVAR.

Thanks for the report. I've changed the way how Tramp suppresses unused
environment variables, unfortunately this new problem doesn't occur when
I run this test locally. Likely, it depends on the shell flavor /bin/sh
is pointing too.

Fixed and pushed, closing the bug.

Best regards, Michael.





  reply	other threads:[~2021-02-19  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 22:03 bug#46625: tramp-test33-environment-variables fails Glenn Morris
2021-02-19  8:25 ` Michael Albinus [this message]
2021-02-19 16:13   ` Glenn Morris
2021-02-19 16:52     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blcg8nw3.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=46625-done@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).