From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Fri, 05 Mar 2021 17:11:54 +0000 Message-ID: <87blbxikyt.fsf@tcd.ie> References: <87im9fgm27.fsf@protesilaos.com> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <87o8g0ryfz.fsf@tcd.ie> <6040d37e.1c69fb81.63467.ad62@mx.google.com> <87wnun9dgo.fsf_-_@protesilaos.com> <87ft1aoj74.fsf@tcd.ie> <87eeguab7o.fsf@protesilaos.com> <60415a04.1c69fb81.63f7a.3bc2@mx.google.com> <877dmmcdnh.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36869"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45068@debbugs.gnu.org, Mauro Aranda To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 05 18:53:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIEdV-0009S9-Mv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 18:53:13 +0100 Original-Received: from localhost ([::1]:32850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIEdU-0001p4-NS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 12:53:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIE0d-0004Vf-JI for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 12:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIE0c-0006Lu-EC for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 12:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIE0c-0006rL-94 for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 12:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Mar 2021 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161496432426300 (code B ref 45068); Fri, 05 Mar 2021 17:13:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 5 Mar 2021 17:12:04 +0000 Original-Received: from localhost ([127.0.0.1]:35348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIDzg-0006q7-35 for submit@debbugs.gnu.org; Fri, 05 Mar 2021 12:12:04 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:55855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIDzd-0006pV-Jo for 45068@debbugs.gnu.org; Fri, 05 Mar 2021 12:12:02 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id w7so2090501wmb.5 for <45068@debbugs.gnu.org>; Fri, 05 Mar 2021 09:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ir0AQa7UysxeC8vgIq0b10cjHq24qMDXV7jzCOv5Wbw=; b=ZHKdJFAspj35RZFCjW+xKJgrMjyY+vTYXzh70dS/fofHRCkQK4QjrjKJXAMO+TAUTp qFdPHo/yp1Yw3kt/0bWZlv54Rci4/CpsbHPchvcOC6aBGootjSkwKVl/qtoda/8INWca GWN6cStpGx7b70Uoy0COufhEDYP19vjVtcdDAwtuG/6o9a+XvrVXaszZdqrWMp47fXMu eId3PIDnkhjt/Pf2nVOAu+D3nz7rQHsHUKzFFa5lPkVCE5JTqsWL1wTlE+IdScMUwzhz IDCo06+FStTGUPCpGxR03dfOg+gsDfdC1s1CGPYshCi+85JcfeaGGVujBAU2EHcECgji Krxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ir0AQa7UysxeC8vgIq0b10cjHq24qMDXV7jzCOv5Wbw=; b=t/WAMF0fD2k3J/nnLjV6DMt3KCyRH1494u57LkBFUytgm7NvN7E+QiR5n8uoE8ZrEL R0i1HpcYKizI47riKRjIWS82mVetXX3Qgqu2+oO6pMf4kTMeMxk/ehJJGWSFEFMCZ+JD H6jerB3k2FKWl3dkiX1VK4IWQHv0J5awcXswwd6XsThPVO+cFnz8P/2IFi2hPiKZb602 97T6a+L29P/bUhobS+sQusRcqjm31mYIBqOLGqKq1wT1NBqB06J0DGn3SeFLHD3yjnWY 7d5c+W3vjgU7fvV/3ak4izAVK3TSz3S4PunVskcF3E3L5aTYX0zMOGpn7fQtEmiI3L9+ QQDQ== X-Gm-Message-State: AOAM530oooqwvpLiRPbhLWpT9AxfW4/li7bH+fHheUkDRdYu/ezomrgr A92d7LA8OF4WpH+uvxqIg1Tg6Q== X-Google-Smtp-Source: ABdhPJyynnzycR3dAjik+pP29dpnl8dceY1Pcgwpd0MH8WxirW+pQvKwqANN44rZxtCtFKsMwRrDdg== X-Received: by 2002:a1c:1b43:: with SMTP id b64mr10049487wmb.79.1614964316112; Fri, 05 Mar 2021 09:11:56 -0800 (PST) Original-Received: from localhost ([51.37.127.115]) by smtp.gmail.com with ESMTPSA id m3sm4939166wmc.48.2021.03.05.09.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:11:55 -0800 (PST) In-Reply-To: <877dmmcdnh.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Fri, 05 Mar 2021 08:34:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201563 Archived-At: Protesilaos Stavrou writes: > On 2021-03-04, 19:06 -0300, Mauro Aranda wrote: > >> But if you plan to keep distributing them as packages via ELPA, then >> it might make sense to keep it. I don't know what's the plan, so I >> can't say for sure if the form should stay or not. > > My original plan was to update the themes in emacs.git and then figure > out what needs to be done for elpa.git to treat them as ":core" packages > instead of ":external". > > So I had this and would have used a similar technique for the > above-quoted code: > > (if (and (>= emacs-major-version 28) > (functionp 'require-theme)) > (require-theme 'modus-themes) > (require 'modus-themes)) > > But that produced a major bug of not loading the desired theme in > certain setups.[1] I suspect it is because 'require' needs to be at the > top level? Not sure... Maybe there is some clean way to fix that, > though I would need more time to research and test it; a time frame that > I cannot estimate right now. > > [1]: . > > So I prefer to use files that 100% work in emacs.git and then I will > treat elpa.git separately. Using all those untested conditional clauses > will give me trouble. Perhaps the themes in elpa.git should not be > ":core" after all? Keeping them as ":external", though updated to the > newest release, seems like the most reliable path forward. > > Ultimately this means more work for me, though I prefer to not have to > deal with packaging-related bugs (notwithstanding the fact that I need > to ask for someone else to push changes for me in Emacs/ELPA and I would > rather not bother them). Ultimately it's your decision as the maintainer, but after addressing the issue you reference above in modus-themes.git, I no longer see any significant hurdles to keeping modus-themes.git / elpa.git / emacs.git in sync, unless I'm missing something? > I appreciate your contributions ("your" singular and plural). For me > this is all part of a learning process and am happy to be part of a > community that (i) tolerates my errors and (ii) helps me learn through > them without making any discounts on technical requirements. That should/does apply to everyone here :). -- Basil