From: haj@posteo.de (Harald Jörg)
To: 46889@debbugs.gnu.org
Subject: bug#46889: cperl-mode: Fix indentation issues [PATCH]
Date: Tue, 09 Mar 2021 18:06:34 +0100 [thread overview]
Message-ID: <87blbs9rz9.fsf@hajtower> (raw)
In-Reply-To: <87im68uwld.fsf@hajtower> ("Harald \=\?utf-8\?Q\?J\=C3\=B6rg\=22's\?\= message of "Wed, 03 Mar 2021 15:43:10 +0100")
haj@posteo.de (Harald Jörg) writes:
> Hello Emacs-Maintainers,
>
> this started out as working on Bug#42169 but it soon became clear that
> there's more lurking in CPerl mode's indentation code, so I decided to
> open a new issue here.
>
> In 7b2448ae (cperl-mode: Improve detection of index entries for imenu),
> committed on Feb 17, the imenu part of Bug#42169 has been fixed. This
> commit now fixes the indentation after a package which brings its own
> block.
>
> Therefore, the patch in this report should finally fix Bug#42169.
>
> As a by-catch, the new code fixes the ancient Bug#8077.
>
> This patch also fixes the first part of Bug#11733. The "other
> indentation bug" reported in Bug#11733 (using a colon as a Perl regexp
> terminator) is a different story and not covered by this patch.
>
> Also fixed now (without known bug number): labels with a space before,
> or a comment after the colon are now correctly indented and fontified.
>
> With this patch in effect, CPerl mode should finally have caught up with
> Perl 5.30!
>
> Many thanks to Mattias Engdegård for his patient explanations how rx
> expressions can be used without breaking compatibility to Emacs 26.1.
> Until now, this allowed two ugly regexp literals to be eliminated.
next prev parent reply other threads:[~2021-03-09 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:43 bug#46889: cperl-mode: Fix indentation issues [PATCH] Harald Jörg
2021-03-04 17:31 ` Lars Ingebrigtsen
2021-03-04 18:07 ` Mattias Engdegård
2021-03-04 18:16 ` Lars Ingebrigtsen
2021-03-04 18:23 ` Mattias Engdegård
2021-03-04 18:34 ` Lars Ingebrigtsen
2021-03-05 10:30 ` bug#46889: Help version guesser bug (was: bug#46889: cperl-mode: Fix indentation issues [PATCH]) Stephen Berman
2021-03-05 13:06 ` bug#46889: Help version guesser bug Lars Ingebrigtsen
2021-03-04 18:19 ` bug#46889: cperl-mode: Fix indentation issues [PATCH] Harald Jörg
2021-03-09 17:06 ` Harald Jörg [this message]
2021-03-09 17:18 ` Harald Jörg
2021-03-10 14:42 ` Lars Ingebrigtsen
2021-05-17 15:28 ` Lars Ingebrigtsen
2021-05-17 21:31 ` Harald Jörg
2021-05-18 13:47 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blbs9rz9.fsf@hajtower \
--to=haj@posteo.de \
--cc=46889@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).