From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47895@debbugs.gnu.org
Subject: bug#47895: 28.0.50; Emacs should only animate images that are visible
Date: Sun, 25 Apr 2021 21:07:48 +0200 [thread overview]
Message-ID: <87bla2ji7v.fsf@gnus.org> (raw)
In-Reply-To: <834kfukx2v.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Apr 2021 22:01:28 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Hm... No, even without the force-update, Emacs uses 100% CPU.
>
> Beware: changing that might make the timer run more frequently, so you
> might see CPU usage soar even though Emacs does almost nothing.
It's still updating at the same rate (25 times a second for the image in
question).
> We access a different frame of the GIF image, so that would mean
> regenerating the pixmap for the image, no?
It does, but why does that happen before redisplay has decided to
display the image?
>> I'd keep interpreting that the same -- that is, count down, even if the
>> image isn't displayed.
>
> But then if and when the image becomes visible, it won't show the
> animation, because it already reached the LIMIT. Right?
Yes. I think that's fine -- you've asked for X repetitions, and you get
X repetitions, whether it's shown or not.
>> Or just compute the position on each iteration -- the image may change
>> its position if more text is inserted, for instance.
>
> Sure, but even if the position doesn't change we currently cannot tell
> if the image is visible. We have pos-visible-in-window-p, but that
> needs a buffer position -- which is why I suggest to record that
> position in the image.
Sure. Could make it a marker, I guess.
>> But I'm still wondering about why this doesn't just work
>> "automatically" -- if we could handle this in the redisplay code, that
>> would be more natural.
>
> Animation doesn't work in redisplay, it works in this code I pointed
> to.
The code just alters some elements in the image plist. It's unexpected
that this should lead to Emacs doing a lot of work -- unless it's
actually displaying the image.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-04-25 19:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 18:19 bug#47895: 28.0.50; Emacs should only animate images that are visible Lars Ingebrigtsen
2021-04-19 18:28 ` Eli Zaretskii
2021-04-19 20:49 ` Lars Ingebrigtsen
2021-04-20 2:24 ` Eli Zaretskii
2021-04-20 13:51 ` Eli Zaretskii
2021-04-25 18:48 ` Lars Ingebrigtsen
2021-04-25 19:01 ` Eli Zaretskii
2021-04-25 19:07 ` Lars Ingebrigtsen [this message]
[not found] ` <YIciJ+1fSjJGcu+P@faroe.holly.idiocy.org>
2021-04-27 15:51 ` Alan Third
2021-04-27 23:23 ` Lars Ingebrigtsen
2021-05-02 9:35 ` Eli Zaretskii
2021-05-03 9:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bla2ji7v.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=47895@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).