From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#7899: 23.2.91; Unsatisfactory interaction between shell-mode-hook and comint-read-input-ring Date: Mon, 10 May 2021 13:16:50 +0200 Message-ID: <87bl9iu9ct.fsf_-_@gnus.org> References: <87y66b3042.fsf@sc3d.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26721"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 7899@debbugs.gnu.org To: Pete Beardmore Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 10 13:17:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg3uS-0006o4-9d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 May 2021 13:17:12 +0200 Original-Received: from localhost ([::1]:44256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lg3uQ-0006Hp-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 May 2021 07:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg3uI-0006Hd-Ir for bug-gnu-emacs@gnu.org; Mon, 10 May 2021 07:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lg3uI-0004OC-Bv for bug-gnu-emacs@gnu.org; Mon, 10 May 2021 07:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lg3uI-0005by-6d for bug-gnu-emacs@gnu.org; Mon, 10 May 2021 07:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 May 2021 11:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7899 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7899-submit@debbugs.gnu.org id=B7899.162064542021498 (code B ref 7899); Mon, 10 May 2021 11:17:02 +0000 Original-Received: (at 7899) by debbugs.gnu.org; 10 May 2021 11:17:00 +0000 Original-Received: from localhost ([127.0.0.1]:57501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg3uG-0005aU-Iy for submit@debbugs.gnu.org; Mon, 10 May 2021 07:17:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg3uF-0005Ve-5f for 7899@debbugs.gnu.org; Mon, 10 May 2021 07:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jUDYLvbRJzcYgbIhg1cG1wMVWSItzvdYyGGTuvL/EVs=; b=j1CRPWw+7nCtCpx5sRkFLHSeGc QdHb9InTSUy5enBFiAgyhRMxPpTsgnIQZdUiyfWuZNDAV/x26cijNPUJz4uUVNpXiNOf7+xzjOOvW NDcWNWzAZy7R1QMJJr4+AbiiDK4fFHIDmoKcSTfQSF6Yh1b01AwkN8ydOLbulRu9Db+g=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg3u7-0007Nx-1Y; Mon, 10 May 2021 13:16:53 +0200 X-Now-Playing: Severed Heads's _Gigapus_: "Arrivederci Coma" In-Reply-To: (Pete Beardmore's message of "Thu, 30 May 2013 13:55:03 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206135 Archived-At: Pete Beardmore writes: > patch 1: > i've extended the original fix for ignoring buffer-local variables to > incorporate 'comint-input-ring-separator', > 'comint-input-history-ignore' and 'comint-input-ignoredups' vars which > suffered from the same issue Thanks for the patch -- it seems like it didn't receive any attention at the time (seven years ago), unfortunately. And if I'm reading the commit logs correctly, this was fixed in 2019 in a slightly different way in commit 9b54d2b66e1e, so I'm closing this bug report. If there's still something to be worked on here, please respond to the debbugs address, and we'll reopne. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no