From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48738: [PATCH] Optimized `describe-variable' predicate Date: Mon, 31 May 2021 07:06:20 +0200 Message-ID: <87bl8rmr03.fsf@gnus.org> References: <55a7f6fc-ccad-a8e3-2f51-1cbc1555a4f8@daniel-mendler.de> <87h7ijmrie.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48738@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 07:07:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lna90-00014J-Gt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 07:07:18 +0200 Original-Received: from localhost ([::1]:52800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lna8z-0000Zc-2q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 01:07:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lna8k-0000ZF-Oj for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lna8k-0002k7-G4 for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lna8k-00058I-AG for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 May 2021 05:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48738 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48738-submit@debbugs.gnu.org id=B48738.162243759219656 (code B ref 48738); Mon, 31 May 2021 05:07:02 +0000 Original-Received: (at 48738) by debbugs.gnu.org; 31 May 2021 05:06:32 +0000 Original-Received: from localhost ([127.0.0.1]:60727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lna8G-00056y-Dg for submit@debbugs.gnu.org; Mon, 31 May 2021 01:06:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lna8E-00056e-Ob for 48738@debbugs.gnu.org; Mon, 31 May 2021 01:06:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pgf3BjNtKzPGSbMkPUtAiFAnCi8ogw3c9ZrCIq56nrE=; b=PJqvnnR3H+xaB501sXPy3CeUbO 3mdivfFWlHynKAqpOIYK5Z81JsVqs0BcV29GbHI8+F6fDLzPxSzTX1KXbWG0JqhqndZJ9pOXfx8Lu K2Lm14k/AFaC0Aab+TsascnvIyZiGf3KHn84QUvvWpJxuX6PIr0sJdPH4OfNFff4n+3M=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lna85-0005fj-8a; Mon, 31 May 2021 07:06:24 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX9/P3T0tOdm5ts aGhPTEuBfX0/PDv////akPEOAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UFHwUDJrUs/P0AAAGpSURB VDjLtZRLcsIwDIZJZtgnBfY00H2LzAGIhNeUTE9Q1/c/QvXLdh6Ubc3w0me9paxW/3La9pm0eiGh 8+tf+cAi5MKpebDiJJ1wbZb3VRajoX5ONmQgQEU+ZmAg56MBvCeVmsiJB/BRX5cRHAimVKQaXnwo KnUGAQA/3ovCQOzMb7AI4k8Gdp8tVh80aB+b4ppLfonGm4E1Iah8ojm65OzOE1BTXkKffLM5gRtk qJkENuC4KHhkiIAtk2oCErQyuOD3DyDmDMUAywh8qnDKvWb+ItySXHpXgPBAU3JQ92KAGHJYY8is nrelhkE4NICoErBPALJwV07OWZSwfn03uSSOkga+1G5MYEtjVCi/3orXVF31kQmsaXdiP85IBogI l1I/qrexJMmUSJ6G3ZS5swA4z896aqDTbIWvZaTJp6HKafI4vVt0QVutHTKlcXhrNNWa7lGSfpr2 ow4aOht81IruZ4uDeuvoaAuZ5vux2rk8JIHvyyU8Bt2doAmeHrf24DQq5tnWlq1vOz34U7UtHgXV /d4tlTfDZ9c1eFBknapYbdvnD490fgFY+rbxDBEtFgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0w NS0zMVQwNTowMzozOCswMDowMJO0BAkAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDUtMzFUMDU6 MDM6MzgrMDA6MDDi6by1AAAAAElFTkSuQmCC X-Now-Playing: Zonal's _Wrecked_: "Debris" In-Reply-To: (Daniel Mendler's message of "Mon, 31 May 2021 07:00:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207655 Archived-At: Daniel Mendler writes: > Yes, when I find such case I will report them or provide a patch. > However it really matters in very few cases. Here the predicate is > called 10k+ times when generating all completions. Yup. I think I'll just go ahead and add `buffer-local-boundp' now -- it'll perhaps encourage further usage of `buffer-local-value'. I remember doing things like (with-current-buffer foo (and (boundp 'zot) zot)) because there's no `buffer-local-boundp'. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no