From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Tue, 20 Jul 2021 15:54:31 +0200 Message-ID: <87bl6xdrag.fsf@gnus.org> References: <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> <83v97x2xum.fsf@gnu.org> <83bl9nevd3.fsf@gnu.org> <831rad5t18.fsf@gnu.org> <835yz26jdk.fsf@gnu.org> <83k0nh6395.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48137@debbugs.gnu.org, Stefan Monnier To: Ioannis Kappas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 20 15:55:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5qDN-000212-No for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 15:55:17 +0200 Original-Received: from localhost ([::1]:36530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5qDM-0003sK-OB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 09:55:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5qD8-0003nm-GP for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 09:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5qD7-00009W-V8 for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 09:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5qD7-0007z7-SM for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 09:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jul 2021 13:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162678928430630 (code B ref 48137); Tue, 20 Jul 2021 13:55:01 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 20 Jul 2021 13:54:44 +0000 Original-Received: from localhost ([127.0.0.1]:33252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5qCq-0007xx-DP for submit@debbugs.gnu.org; Tue, 20 Jul 2021 09:54:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:57770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5qCo-0007xg-77 for 48137@debbugs.gnu.org; Tue, 20 Jul 2021 09:54:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=usjVBUaqSJBlHm2SLigCDgDMxtCCbLCWaENNnutp0Jw=; b=GyVLBnzYQYt6CuUd/Kz4Eks0Ft n2v59ZmgQtuTDd6zMwFajJjPy3+X//i1tif6jJsUEttlSRLDBKTTOGneyComaO1yf8EioD6BMogIo sCosAmVyz3/V2PbWfkYi4QqQRUPUYU8dzXu6CivQnPOnhdzad6gA629bB69TDPTVT8BI=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5qCe-0003sh-2j; Tue, 20 Jul 2021 15:54:34 +0200 X-Now-Playing: Unbalance's _Fabric 94: Steffi_: "Freedom" In-Reply-To: (Ioannis Kappas's message of "Sun, 6 Jun 2021 10:11:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210354 Archived-At: Ioannis Kappas writes: >> Thanks. Yes, that's a good idea. Ioannis, could you perhaps add some >> tests, both using existing packages and perhaps also some you concoct >> just for testing purposes? > > Please find attached a patch with the earlier fix and two new ert > package tests. Skimming this thread, it seemed people agreed that this was the right solution, so I've now installed the patch in Emacs 28. This change was just small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no