unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50503@debbugs.gnu.org
Subject: bug#50503: [PATCH] Properly encode all strings sent to the Python shell
Date: Sat, 11 Sep 2021 14:44:28 +0200	[thread overview]
Message-ID: <87bl4z1dub.fsf@gmail.com> (raw)
In-Reply-To: <87r1dvmgm4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 11 Sep 2021 14:38:59 +0200")

On Sat, 11 Sep 2021 at 14:38, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Augusto Stoffel <arstoffel@gmail.com> writes:
>
>> Thanks!  But note that there is at least one Emacs 28 dependency left,
>> namely `comint-max-line-length'.
>
> Perhaps there should be some compat code in that case?

If it is stylistically acceptable, I think

  (or (bound-and-true-p comint-max-line-length) 1024)

is the simplest solution.  One could also replace the mysterious 1024 by
0, which was more or less the previous situation anyway.

>
>> There's also a byte-compiler warning regarding
>> `comint-highlight-input' even on Emacs 27.
>
> Warnings are normal on older Emacs versions -- I mean, it'd be good to
> avoid them, but we're mainly worried about actual breakages.

All right then.





  reply	other threads:[~2021-09-11 12:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 10:40 bug#50503: [PATCH] Properly encode all strings sent to the Python shell Augusto Stoffel
2021-09-10 11:07 ` Lars Ingebrigtsen
2021-09-10 16:16   ` Augusto Stoffel
2021-09-11 12:38     ` Lars Ingebrigtsen
2021-09-11 12:44       ` Augusto Stoffel [this message]
2021-09-11 12:45         ` Lars Ingebrigtsen
2021-09-11 13:32           ` Augusto Stoffel
2021-09-11 13:39             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl4z1dub.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=50503@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).