From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#50679: 28.0.50; outline-minor-mode-cycle should be able to only cycle at the begining of a line Date: Mon, 20 Sep 2021 15:35:04 +0000 Message-ID: <87bl4nuuon.fsf@posteo.net> References: <87r1dkv8i2.fsf@posteo.net> <87mto8h5hk.fsf@mail.linkov.net> <87mto8uwnu.fsf@posteo.net> <87fstzn2zw.fsf@mail.linkov.net> <87y27rpi4q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1200"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50679@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 17:38:57 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSLNf-000053-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 17:38:55 +0200 Original-Received: from localhost ([::1]:44850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSLNe-0007hx-5r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 11:38:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSLKs-0003Nr-8C for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 11:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSLKr-0005uh-TJ for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 11:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSLKr-0002Fc-RI for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 11:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50679 X-GNU-PR-Package: emacs Original-Received: via spool by 50679-submit@debbugs.gnu.org id=B50679.16321521158550 (code B ref 50679); Mon, 20 Sep 2021 15:36:01 +0000 Original-Received: (at 50679) by debbugs.gnu.org; 20 Sep 2021 15:35:15 +0000 Original-Received: from localhost ([127.0.0.1]:43886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLK7-0002Dq-ET for submit@debbugs.gnu.org; Mon, 20 Sep 2021 11:35:15 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:53745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLK4-0002DS-JE for 50679@debbugs.gnu.org; Mon, 20 Sep 2021 11:35:13 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 3E018240028 for <50679@debbugs.gnu.org>; Mon, 20 Sep 2021 17:35:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1632152106; bh=C4OHLJK8OV2PL2R1NUrSOr/icxWtTtV3rt0e66UuxBE=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=me+PeEqRnE7W4ShSLEab3FevOwg8xZhG8oUn9G7HE/sUG38YdE5C30o/aHIpZJXg9 F9eRv5IeSSch1d7i1wo41/59ZF9PQoF4op9l9hDn73zLA6GIg84IrXgj+Tw+dQy07A JaUwslpVRBJE+a15UpcfI77+xgOUqpG9lRz51bNctEpL983IETx4jFQ+zcqke9hlpO T0Aft/HR+wbOxokCrJ/5JxBOyBLy283CL4EukVdNZuWRS05hG5AHiUxA42T09vIUbr +3GbdPt1oSyRxwaA5ZPpJ12Bo/zg8P7povjCd+ri+ggUtkkOqlZdfoL6CiGDpLWZV6 IMF4v1g4L0XaQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HCpXT2LPLz6tmM; Mon, 20 Sep 2021 17:35:05 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87y27rpi4q.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 20 Sep 2021 18:25:09 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214870 Archived-At: Juri Linkov writes: >>> I didn't necessarily propose anything, it might only be able to solve >>> this using a option like >>> >>> (defcustom outline-minor-mode-cycle-predicate ...) >>> >>> as to allow for users to configure cycling as they see fit. Of course if >>> some consistent behaviour could be found that respects other options and >>> modes, then something automatic could also be used. >> >> Probably offloading the decision to the users with a customizable option >> is all what we can do here, indeed. > > Maybe something like: > > (defvar outline-mode-cycle-map > (let ((map (make-sparse-keymap))) > (let ((tab-binding `(menu-item > "" outline-cycle > ;; Only takes effect if point is on a heading. > :filter ,(lambda (cmd) > - (when (outline-on-heading-p) cmd))))) > + (when (and (outline-on-heading-p) > + (or (not (functionp outline-mode-cycle-filter)) > + (funcall outline-mode-cycle-filter))) > + cmd))))) > (define-key map (kbd "TAB") tab-binding) > (define-key map (kbd "") #'outline-cycle-buffer)) > map) > > Then you can customize it to 'bolp'. I just tried it out, and it looks good. The only thing I wonder is if this should apply to both outline-minor-mode and outline-mode? -- Philip Kaludercic