From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse Date: Sun, 03 Oct 2021 20:42:56 +0300 Organization: LINKOV.NET Message-ID: <87bl4657j3.fsf@mail.linkov.net> References: <8735ptxhzs.fsf.ref@yahoo.com> <8735ptxhzs.fsf@yahoo.com> <87wnn5m8eo.fsf@gnus.org> <83wnn5qe48.fsf@gnu.org> <87k0j5m5ik.fsf@gnus.org> <83tui9qd2j.fsf@gnu.org> <87fsttm512.fsf@gnus.org> <87y27kbi6y.fsf@mail.linkov.net> <83a6k0phik.fsf@gnu.org> <878rzi11xq.fsf@mail.linkov.net> <83lf3hlv5o.fsf@gnu.org> <87czoso8cz.fsf@mail.linkov.net> <834k9zd9i3.fsf@gnu.org> <87ee93fbw8.fsf@mail.linkov.net> <83pmsm8h1o.fsf@gnu.org> <87a6jq9kdv.fsf@mail.linkov.net> <835yue81lz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: luangruo@yahoo.com, larsi@gnus.org, 50798@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 03 19:50:02 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mX5cf-0002wj-VS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Oct 2021 19:50:01 +0200 Original-Received: from localhost ([::1]:58122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5cd-00052f-PH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Oct 2021 13:49:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5Xq-0001SV-KJ for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 13:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5Xq-0006MB-C6 for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 13:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mX5Xq-00067I-AA for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2021 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50798 X-GNU-PR-Package: emacs Original-Received: via spool by 50798-submit@debbugs.gnu.org id=B50798.163328304323419 (code B ref 50798); Sun, 03 Oct 2021 17:45:02 +0000 Original-Received: (at 50798) by debbugs.gnu.org; 3 Oct 2021 17:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:34879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mX5Wt-00065f-AY for submit@debbugs.gnu.org; Sun, 03 Oct 2021 13:44:03 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:38925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mX5Wr-000654-7V for 50798@debbugs.gnu.org; Sun, 03 Oct 2021 13:44:02 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id DAA0F240007; Sun, 3 Oct 2021 17:43:53 +0000 (UTC) In-Reply-To: <835yue81lz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Oct 2021 20:22:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216288 Archived-At: >> It's possible to put properties on the close button only, but wouldn't this be >> too ugly? This means that hovering the mouse over the tab name will highlight only >> the tab name without highlighting the close button. And hovering the mouse >> over the close button will highlight only the close button without highlighting >> the tab name. > > How did you intend this to look? You said previously: > >> 'tab-line-close-highlight' was supposed to be applied to the close button >> to emulate how the close button behaves on the tab bar where hovering mouse >> over the button displays it with the face style 'released-button'. >> >> But mouse-face of the face 'tab-line-highlight' overrides the mouse-face >> 'tab-line-close-highlight' in 'tab-line-tab-name-format-default' >> that applies 'propertize' with 'mouse-face tab-line-highlight'. > > If what you intended was not to highlight the close button > differently, then what was the intent? The intent for the close button was to look exactly like the close button on the tab-bar. Well, almost. Because while the close button hovering looks nice on the tab-bar, it has another problem that hovering its tab doesn't highlight it like mouse-face highlights the tab on the tab-line. So both the tab-bar and the tab-line are still not perfect. >> So highlighting will be separate for the close button and >> the rest of the tab with such patch: > > Does this solve the problem with vertical movement of the button? It solves the problem because tab-line-close-highlight doesn't inherit from other faces. It's face inheritance that caused the problem with vertical movement of the button.