From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45688: 28.0.50; New action for display-buffer? Date: Mon, 04 Oct 2021 20:31:00 +0300 Organization: LINKOV.NET Message-ID: <87bl44d98r.fsf@mail.linkov.net> References: <87im8a1dff.fsf@gnus.org> <83o8i20w1f.fsf@gnu.org> <87lfd5yny9.fsf@gnus.org> <87o8i03gem.fsf@gnus.org> <528b7d6b-403a-ffef-b0a0-4a0b6d92bec8@gmx.at> <87turpvxv0.fsf@gnus.org> <87turnh6u8.fsf@gnus.org> <87im83cn02.fsf@gnus.org> <568151d0-c8fd-1643-56a7-87ff36ce234d@gmx.at> <8735ywdf0q.fsf@mail.linkov.net> <87lfcnqo3q.fsf@mail.linkov.net> <87ft2osrs7.fsf@mail.linkov.net> <87tuhy2cku.fsf@mail.linkov.net> <3ab5fd34-ac8f-86cd-f0b7-5cfdf7befa40@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33566"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 45688@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 04 19:47:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXS3d-0008Ub-SQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Oct 2021 19:47:21 +0200 Original-Received: from localhost ([::1]:44400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXS3c-00049U-Sd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Oct 2021 13:47:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXS3L-00048t-R7 for bug-gnu-emacs@gnu.org; Mon, 04 Oct 2021 13:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXS3J-0004ex-PI for bug-gnu-emacs@gnu.org; Mon, 04 Oct 2021 13:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXS3J-0006rO-Lg for bug-gnu-emacs@gnu.org; Mon, 04 Oct 2021 13:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Oct 2021 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45688 X-GNU-PR-Package: emacs Original-Received: via spool by 45688-submit@debbugs.gnu.org id=B45688.163336961926361 (code B ref 45688); Mon, 04 Oct 2021 17:47:01 +0000 Original-Received: (at 45688) by debbugs.gnu.org; 4 Oct 2021 17:46:59 +0000 Original-Received: from localhost ([127.0.0.1]:38322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXS3G-0006r7-OG for submit@debbugs.gnu.org; Mon, 04 Oct 2021 13:46:58 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:54473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXS3C-0006qV-15 for 45688@debbugs.gnu.org; Mon, 04 Oct 2021 13:46:57 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C93F41BF207; Mon, 4 Oct 2021 17:46:46 +0000 (UTC) In-Reply-To: <3ab5fd34-ac8f-86cd-f0b7-5cfdf7befa40@gmx.at> (martin rudalics's message of "Mon, 4 Oct 2021 10:28:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216377 Archived-At: >>>> Indeed, better would be to add an option to not resize it by describe-function. >>>> Maybe by adding a new option 'after-display-buffer-function' and set it >>>> by default to 'shrink-window-if-larger-than-buffer' in *Help* buffers? >>> >>> You can already use a 'window-height' alist entry and set it to >>> 'shrink-window-if-larger-than-buffer'. What would an >>> 'after-display-buffer-function' option do differently? >> >> It seems the patch that you recently sent to emacs-devel fixes this problem? > > You mean this problem > > The problem is that currently shrink-window-if-larger-than-buffer > is used in many commands by default, but this behavior is hard-coded > and can't be disabled by customization. These commands include > help commands, vc-log, vc-diff, ... > > supposedly caused by 'temp-buffer-resize-mode'? Your recent patch in emacs-devel allows customization of help commands, but not vc-log, vc-diff. A separate request could be created for customization of shrink-window-if-larger-than-buffer in vc-log, vc-diff. (I mistakenly assumed that help-mode uses shrink-window-if-larger-than-buffer, but actually help-mode resizes with 'temp-buffer-resize-mode'). > Would we then be able to close this bug or is there anything else left? I don't know, Lars opened this request. And I reported this problem only after you mentioned 'temp-buffer-resize-mode'.