From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12504: 24.2.50; `bookmark-rename' and `bookmark-maybe-historicize-string' Date: Sat, 04 Dec 2021 05:58:35 +0100 Message-ID: <87bl1xotj8.fsf_-_@gnus.org> References: <736CB5A93DF64F6BB3FDF32A163C35B3@us.oracle.com> <87lifqhmj2.fsf@floss.red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22650"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 12504@debbugs.gnu.org To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 04 05:59:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtN94-0005kY-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 05:59:34 +0100 Original-Received: from localhost ([::1]:52912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtN92-0006BO-Ej for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Dec 2021 23:59:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtN8Z-0006Ay-5i for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 23:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtN8Y-0006KZ-ME for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 23:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtN8Y-00014x-DY for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 23:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 04:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12504 X-GNU-PR-Package: emacs Original-Received: via spool by 12504-submit@debbugs.gnu.org id=B12504.16385939274110 (code B ref 12504); Sat, 04 Dec 2021 04:59:02 +0000 Original-Received: (at 12504) by debbugs.gnu.org; 4 Dec 2021 04:58:47 +0000 Original-Received: from localhost ([127.0.0.1]:52756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtN8J-00014E-7n for submit@debbugs.gnu.org; Fri, 03 Dec 2021 23:58:47 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:60708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtN8H-00013w-AP for 12504@debbugs.gnu.org; Fri, 03 Dec 2021 23:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9fgNYaVNLJ8j+pdb+TT1b4qsyIENNFcXmwL1XkNiPX0=; b=NGS819UMRvFoVzEQZQLCffmRUd Raw/59bJJUL49256kCXChzk0cauCApf/be1Elui2yQqX+Njk6yzbCSMWwXzN0GX4MK5CBAzh+v84T jW+ECHSjAsKFtzZ3TJYpSc/1VqCmBoAY+uoDXQfebiCGTCVhS97MYgwnFiPYjuMoSuQU=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtN88-0002dF-2Z; Sat, 04 Dec 2021 05:58:38 +0100 X-Now-Playing: Neil Young's _Harvest_: "Heart Of Gold" In-Reply-To: <87lifqhmj2.fsf@floss.red-bean.com> (Karl Fogel's message of "Sun, 30 Sep 2012 22:57:37 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221437 Archived-At: Karl Fogel writes: > Does invoking functions through a menu result in an environment where > `called-interactively-p' returns non-nil? In that case, the premise > behind `bookmark-maybe-historicize-string' is all wrong anyway, and the > macro should be rewritten to: > > `(when (called-interactively-p 'interactive) > (setq bookmark-history (cons ,string bookmark-history)))) The doc string is misleading -- this isn't about normal menus, but functions like this: (defun bookmark-bmenu-rename () "Rename bookmark on current line. Prompts for a new name." (interactive nil bookmark-bmenu-mode) (let ((bmrk (bookmark-bmenu-bookmark)) (thispoint (point))) (bookmark-rename bmrk) (goto-char thispoint))) So I've now updated the doc string. > By the way, your guess is right: it's useful (I think) to have the old > name in the history for `bookmark-rename', because someone may want to > use it or a variant of it in another bookmark soon. History is cheap > that way: it's better to have a little junk than to *not* have the thing > the user needs when they need it. So I think this is working as designed, and I'm therefore closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no