From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#53362: 29.0.50; [PATCH] Make Completions sorting a user option Date: Wed, 19 Jan 2022 15:17:13 +0200 Message-ID: <87bl07lvae.fsf@protesilaos.com> References: <87h79zlxmg.fsf@protesilaos.com> <83wnivsx2f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.34.2 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 53362@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 19 14:28:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAB0T-0003g7-I0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jan 2022 14:28:09 +0100 Original-Received: from localhost ([::1]:39944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAB0R-0007S9-89 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jan 2022 08:28:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAAqj-0008VF-Bx for bug-gnu-emacs@gnu.org; Wed, 19 Jan 2022 08:18:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAAqg-0001Hp-Qo for bug-gnu-emacs@gnu.org; Wed, 19 Jan 2022 08:18:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAAqg-0007D1-JM for bug-gnu-emacs@gnu.org; Wed, 19 Jan 2022 08:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jan 2022 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53362-submit@debbugs.gnu.org id=B53362.164259824427648 (code B ref 53362); Wed, 19 Jan 2022 13:18:02 +0000 Original-Received: (at 53362) by debbugs.gnu.org; 19 Jan 2022 13:17:24 +0000 Original-Received: from localhost ([127.0.0.1]:52660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAAq4-0007Bs-Fi for submit@debbugs.gnu.org; Wed, 19 Jan 2022 08:17:24 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:37733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAAq1-0007Ba-Uo for 53362@debbugs.gnu.org; Wed, 19 Jan 2022 08:17:23 -0500 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id C2E9B100011; Wed, 19 Jan 2022 13:17:14 +0000 (UTC) In-Reply-To: <83wnivsx2f.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224570 Archived-At: On 2022-01-19, 14:56 +0200, Eli Zaretskii wrote: >> From: Protesilaos Stavrou >> Date: Wed, 19 Jan 2022 14:26:47 +0200 >> >> +(defcustom completions-sort 'lexicographic >> + "Sort candidates in the *Completions* buffer. >> + >> +The value can be nil to disable sorting altogether, >> +`alphabetical' for alphabetical sorting, `lexicographic' for >> +lexicographic sorting > > Here you expect everyone to understand the subtle difference between > these two sorting orders. I don't think this expectation is > reasonable. Perhaps it is better to reference string-lessp and string-version-lessp directly? >> + ('alphabetical (sort completions #'string-version-lessp)) > > Doesn't string-version-lessp do stuff that is only appropriate with > version numbers like 1.2.3beta? It also helps when the string starts with a number: (sort '("1 test" "21 test" "11 test" "2 test") #'string-lessp) ;; => ("1 test" "11 test" "2 test" "21 test") (sort '("1 test" "21 test" "11 test" "2 test") #'string-version-lessp) ;; => ("1 test" "2 test" "11 test" "21 test") -- Protesilaos Stavrou https://protesilaos.com