From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54060: 29.0.50; diff-buffers should take narrowing into account Date: Sat, 19 Feb 2022 13:29:23 +0100 Message-ID: <87bkz3xcnw.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10940"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54060@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 19 13:31:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLOtD-0002gd-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Feb 2022 13:31:03 +0100 Original-Received: from localhost ([::1]:36202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLOtB-0004bs-Ud for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Feb 2022 07:31:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLOsL-0004bP-NX for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 07:30:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLOsF-0004kS-FK for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 07:30:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLOsE-0005MR-W1 for bug-gnu-emacs@gnu.org; Sat, 19 Feb 2022 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Feb 2022 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54060 X-GNU-PR-Package: emacs Original-Received: via spool by 54060-submit@debbugs.gnu.org id=B54060.164527377720551 (code B ref 54060); Sat, 19 Feb 2022 12:30:02 +0000 Original-Received: (at 54060) by debbugs.gnu.org; 19 Feb 2022 12:29:37 +0000 Original-Received: from localhost ([127.0.0.1]:57038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLOrp-0005LO-Ie for submit@debbugs.gnu.org; Sat, 19 Feb 2022 07:29:37 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:43548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLOro-0005LB-E3 for 54060@debbugs.gnu.org; Sat, 19 Feb 2022 07:29:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mZ9jMEH1ZiLhROUlNCfprY2x9xKW6g+B2IFYuQ7z0tU=; b=NffpwuIMbC2dXWAqOh7t4NkDnP 3F2ulJheLbM16qZtgjw0vwzWdk+04i5QiNwS6ACul0HCyJWlp2b4z5teOJuvUaFkerE+6GEX+Nug9 IEX2XTfoecn04DQdRlF1UEUimnT+yZvL/EJLe1igWnGdJZiFM/WwheNv65+H/TTLcyjc=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLOrc-0006JV-H3; Sat, 19 Feb 2022 13:29:29 +0100 X-Now-Playing: Tuxedomoon's _Ten Years In One Night (Live)_: "Reedin', Rightin', Rhythmatic" In-Reply-To: (Philipp Stephani's message of "Fri, 18 Feb 2022 19:06:53 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227184 Archived-At: Philipp Stephani writes: > Unlike ediff-buffers, diff-buffers always compares the entire buffer > contents, not the accessible portion. I think it would be better to > restrict the diff to the accessible portion, since normally buffer > commands only act on the accessible portion (and the capability to > compare only portions of buffers is occasionally quite useful!). Makes sense to me, but I rarely use diff-buffers, so I don't really know what the expectations are. > IIUC the only change needed would be to replace (write-region nil nil > ...) in diff-file-local-copy with (write-region (point-min) > (point-max) ...). If we don't want to change the default behavior, > then this could be made configurable with a customization option. I think it would make sense to change the default behaviour, but perhaps have an option to switch it back to the old behaviour. Any opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no