From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#54034: 29.0.50; Diff prettify broken for empty files Date: Sun, 20 Feb 2022 17:50:26 +0100 Message-ID: <87bkz1jxd9.fsf@gmail.com> References: <87iltex7bo.fsf@gmail.com> <87v8xakm0i.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31517"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54034@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 20 17:52:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLpRW-0007v8-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 17:52:14 +0100 Original-Received: from localhost ([::1]:45330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLpRV-0000o5-KB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 11:52:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLpQa-0007lK-3P for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 11:51:17 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLpQM-0000AJ-3e for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 11:51:15 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLpQL-0007q8-V0 for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 11:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Feb 2022 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54034 X-GNU-PR-Package: emacs Original-Received: via spool by 54034-submit@debbugs.gnu.org id=B54034.164537583430102 (code B ref 54034); Sun, 20 Feb 2022 16:51:01 +0000 Original-Received: (at 54034) by debbugs.gnu.org; 20 Feb 2022 16:50:34 +0000 Original-Received: from localhost ([127.0.0.1]:33626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLpPt-0007pR-TR for submit@debbugs.gnu.org; Sun, 20 Feb 2022 11:50:34 -0500 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:34570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLpPt-0007pF-6M for 54034@debbugs.gnu.org; Sun, 20 Feb 2022 11:50:33 -0500 Original-Received: by mail-wr1-f42.google.com with SMTP id d3so7458168wrf.1 for <54034@debbugs.gnu.org>; Sun, 20 Feb 2022 08:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RQlpgSx4tRJ575MUu8pJNwMcZdDyxMZSbbKfhxIrdy0=; b=gtme31Mnj7jFi0Uv+qufLwifReqA/9a6TweFSX+TSIqZHk3YYuwLb/8hhNRhPFPYBs rwwoTPA05cXBSI50+GLomEYS+T/pKPBbO9nDLHDtxd//hwtbtmLcmWHwpkQ+qnYf260i vyS7zuWzYR2vbhZHPKv/Now0ve8r7iuBw/YU/yIY4LgihXsK9oAvV5IEP0ZZR5/EjA+Q 5fZox/uXp4rb1NmzF/+DIrtrAuvehRmcqhvJKd8peyfhq0EVhq1SflWAiHOX9ZBYJxH/ 3bM3vyB4DtmtynXc3p++DIqqT+mmXTU96IBqUYv94T0WFQYHyjtWpN57srsyEvzpxQr+ IVEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RQlpgSx4tRJ575MUu8pJNwMcZdDyxMZSbbKfhxIrdy0=; b=ORhGJgmqep5P2oj86bYGI2xpPf05XjVC4MwXLw4z2HB8VUBVNLtb9QakmrJALC7miD 99bR+p9C6q7V9uG8mWRYJQK+LcffF+vgK5SaEv22X7xqvBMbFEnclSjZQwBV4GYikjLL BEDiMH3tPROMB+30CxFW8UMlfyKb/RRqHNnUARvt5ApXHIbCgK+c6k9Wn+12oD5WJEf+ uf0cBGxAx8MYstdlzpCV/VWvENIHc8mHCGK1BroXqkYPmBzwjzVzYZl5+DZFvR1zJoJ/ VVdZgv8jmR4Q0stHrs6h4Idd6H+1lV+Yq25xNKglSopbLeIDVSft4Sdret0jJWV7WNsS 0X8g== X-Gm-Message-State: AOAM530LNaddkG3169BQuk1LNuLvMsZCdSFQrQGTYot0KhB6Sx0K7WJq 8aVIc9hU3Y6yOKUZxm/E24r3nvDgeroIqw== X-Google-Smtp-Source: ABdhPJyKt2wQwdM9etUUEDJeMBKgLvIvs/82KFhUdIiBSKUaBOF2F03pAXrbEq7rG0FuRTQuGy3WXg== X-Received: by 2002:a5d:59a1:0:b0:1e9:3b2c:76b8 with SMTP id p1-20020a5d59a1000000b001e93b2c76b8mr8955125wrr.486.1645375827315; Sun, 20 Feb 2022 08:50:27 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id l5sm5655833wmq.7.2022.02.20.08.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 08:50:26 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sun, 20 Feb 2022 09:40:52 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227259 Archived-At: Stefan Monnier writes: > (...) It should be easy to handle those cases as well. Can you > suggest a good replacement? (i.e. what should we display instead of > the "diff --git ..." stuff) When the empty file empty.py is added, I expect to read: new file empty.py Analogous expectations with "deleted " and "modified ", the file being a binary file or not. Thus my suggestion is to use exactly the same replacement as for non-empty, text files! It looks like being empty or binary, implies that the diff won't output +++, nor --- lines, which makes current regex inappropriate.