From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54245: 29.0.50; select usage in GNUstep Date: Sat, 05 Mar 2022 08:45:03 +0800 Message-ID: <87bkylqlbk.fsf@yahoo.com> References: <877d99g2g1.fsf@gnus.org> <87r17hhexs.fsf@gmail.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28461"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen , 54245@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 05 01:46:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQIYw-0007Gr-5c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Mar 2022 01:46:22 +0100 Original-Received: from localhost ([::1]:34676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQIYu-0005aG-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 19:46:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQIYc-0005Zu-7W for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 19:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQIYb-0007F4-S1 for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 19:46:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nQIYb-0002Sf-PF for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 19:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Mar 2022 00:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54245-submit@debbugs.gnu.org id=B54245.16464411229411 (code B ref 54245); Sat, 05 Mar 2022 00:46:01 +0000 Original-Received: (at 54245) by debbugs.gnu.org; 5 Mar 2022 00:45:22 +0000 Original-Received: from localhost ([127.0.0.1]:47006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQIXy-0002Rj-M0 for submit@debbugs.gnu.org; Fri, 04 Mar 2022 19:45:22 -0500 Original-Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:38121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQIXw-0002RP-Kl for 54245@debbugs.gnu.org; Fri, 04 Mar 2022 19:45:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646441114; bh=m6cabS0SGq6Ccx8g9KtULt9boIGklnc/BQjelvaQ+wI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Jh6IE8OdnO1l13ohHAJFMSnbmUnqc3WFtk6N60S2a3kE73LLx/9FflcdfUt4xRxUv0RoyQo+FTS2ypVyYHgURFqoZ9E8FUB8LpLejrEIkqzdXoAgQ7Lhl+NB66btzsGOZUZxWsBg66neOpcTlf4TPIVLPZTDaEYXaziJenAasKN+RJUrwD9ZVCrQmyJ1LyVEY+Uy72os1TVo6f7AA5aRzAN4CmZd8/aVajJVrolNx48QkUmfve+p9yPY7n3n/MONcIwE4OUC2k+wOUOCRUqOx31s7T5JLeAm6fSJT/HPVXCtzGynNP9Xl0962JZdhpC9CRgBE4C12lWTie7RspH3yQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646441114; bh=zwtfBSl2mD5sCEtdlp7IxlfazeoFpkxvpolvJVOY3sX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ifJ1FFwEVBQet6zRTWdu5mQ5MThRLUq4RHhvBXTQtZARn/1SslSm4b5bvcOAioS0kL0TTAdHZezvCZCO2ZkVh5nU2lsPqRKy4teu3qScC6qHkBwLIecczaVkzOCeHfrVM2y2AT5w4wMT28CKrQPpnV2sEFI9ErUFJwiZVvCOH31vT6KQUQstbtSifKQdPLcaZwMLjgvkhv11uutXzpDgrDxKoGx9ln6ZJLoa6d7bIFWSJtRqcFj7w1qwq3vo2q7Wa2YgeJi0nc0FmSmWBj0sA4Vfu0wGFTZ4IAM4KXGl28hHNOvuz4vbreiSOChhkxxfP8874waid5ndESKccZcS4A== X-YMail-OSG: BItNABIVM1ml2CJhZcumt8mngw36Hmu2kYwU2612z00r.xUEos.WG_QRtYtnoEx s2Fbi8SBs3PiT.U5JGpJDlQRWr67f_HZsDIajNFDRGdm2Bc9BO6jpCjJssBsSj1F68SNqG4NdHJ8 u4lYHp9M1XtMwRTSpRUD3YT0kcSDRwqdAZ44mjse5txot3_FoaObYhvhEmi0NI8gShNgSFyaTMwn 03DGPwwc7RP94bxK6amOHIfdhsmblUfOC12T3c3pWgo_XuQ7SU2lbeUInNUeKGlBNzyjhLdGecCA 5d2RTcTXz_MYOevzWwQhLEIjID8DsOSRAev2QBvP5_KlKwmYH_G.tkIrw8OQP7bLPdzMh2x7E5Lc xUdEOVbhvjay6VKcQWq70sw51asEKMushgalLwICL9cVCr2YXgiPlQ_yom3szWVI3wsLpVlX.PzU oU0iUEgVQJrvBhxNIHvlhnMUX4CtJpBW5dkpHk58oZ6ngl_9vzzE5szUyFHWF7Pdpp8a9X68x281 eT_uYLXWgX.69wSNQBsl2FCHWtiyJ59vOzP82uTAZKwCAhWtNZceCPlskaVXdBNAhaNQEIe118vS nYIvcIEVwrR1uaPn.5dwXQwuRSwOJq1G8HtzE8Kd9tEeeI25f2l380RlR7rrTTjC8xnreztD15sK 0ByS.tgv4VKRe1beSAeLgqJPnKmJgvIi43KdmvryqM.nydS_J4pSfCdFbhMP1aFB4JuC2RHkZDfk E79ssjjsJx1ci2uau8P17HODbCldy6SezHxeLpnApB.8mtDtBrGffBLarMn8ZZ2jwydVPz2RwFJX Ltzy26Q4wEEzf5le8GR.bgGaaWgyQp2GQDr2j6kSmm X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 5 Mar 2022 00:45:14 +0000 Original-Received: by kubenode519.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b9c0a61e6e1d97932cecebaeb637113a; Sat, 05 Mar 2022 00:45:07 +0000 (UTC) In-Reply-To: <87r17hhexs.fsf@gmail.com> (Robert Pluim's message of "Fri, 04 Mar 2022 17:15:27 +0100") X-Mailer: WebService/1.1.19797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228015 Archived-At: Robert Pluim writes: > I=CA=BCve been running with the following for a whole two days with no ill > effects (and the resulting emacs binary does not contain any calls to > 'select'). Last time I looked, emacs never seems to use the sigmask > parameter to 'pselect' anyway, so it=CA=BCs kind of a moot point. > > diff --git a/src/nsterm.m b/src/nsterm.m > index 670f8971df..4eb32de654 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -5830,7 +5830,7 @@ - (void)fd_handler:(id)unused > fd_set fds; > FD_ZERO (&fds); > FD_SET (selfds[0], &fds); > - result =3D select (selfds[0]+1, &fds, NULL, NULL, NULL); > + result =3D pselect (selfds[0]+1, &fds, NULL, NULL, NULL, NULL); > if (result > 0 && read (selfds[0], &c, 1) =3D=3D 1 && c =3D=3D= 'g') > waiting =3D 0; > } > > Robert That LGTM, but I only tested on GNUstep. The same code is also used on macOS, so there might be some side effects. Though the NS port is very old and I get the feeling that we keep bumping into relics from over two decades ago, and using `select' might very well be one of those. Thanks.