From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#54343: 28.0.91; find-function goes to a wrong place for erc Date: Sat, 12 Mar 2022 19:09:30 -0800 Message-ID: <87bkya8s5x.fsf@neverwas.me> References: <87h783ys33.fsf@gnus.org> <87wngyad1h.fsf@neverwas.me> <87tuc2vfa6.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19368"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lin Jian , 54343@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 13 04:10:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTEco-0004s9-I2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 04:10:30 +0100 Original-Received: from localhost ([::1]:56746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTEcm-0004F3-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Mar 2022 22:10:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTEcM-0004Ev-Mf for bug-gnu-emacs@gnu.org; Sat, 12 Mar 2022 22:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTEcM-0003lp-Dm for bug-gnu-emacs@gnu.org; Sat, 12 Mar 2022 22:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTEcM-0001pZ-66 for bug-gnu-emacs@gnu.org; Sat, 12 Mar 2022 22:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2022 03:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54343 X-GNU-PR-Package: emacs Original-Received: via spool by 54343-submit@debbugs.gnu.org id=B54343.16471409867012 (code B ref 54343); Sun, 13 Mar 2022 03:10:02 +0000 Original-Received: (at 54343) by debbugs.gnu.org; 13 Mar 2022 03:09:46 +0000 Original-Received: from localhost ([127.0.0.1]:41300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTEc6-0001p1-CQ for submit@debbugs.gnu.org; Sat, 12 Mar 2022 22:09:46 -0500 Original-Received: from mail-108-mta194.mxroute.com ([136.175.108.194]:42479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTEc2-0001ol-Cr for 54343@debbugs.gnu.org; Sat, 12 Mar 2022 22:09:43 -0500 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta194.mxroute.com (ZoneMTA) with ESMTPSA id 17f8140acb0000763e.001 for <54343@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 13 Mar 2022 03:09:33 +0000 X-Zone-Loop: fb32bca1304f2e6283c34b4cc56a8f10774e785081ce X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d3YTsjxw11n/7Yf6N2q+GUeOfC/HrV/+3AGO8F+1c+o=; b=BF9IpB1k3aYgfETPNiFazNYML2 xRxTWCffekXD2XWugiJK7vCe2eftCr12bcw8Snnc9YZuy5+MxInvHzA6+1X3FQeR9qnkV3NSpLzCe DxMD464qHmFhhx7lifqeBvENGvikATPVmakBLsf8bIoQnOpJNWkPknOLRHRkAj5WhAJpqBwj9KPyV Ex5M2+G211Zup5TAKsPn2Kf/PCnQHAtJLxhPssolWisIvR64VdYqF81MzCPtR0XA93EACEW619QY0 w3L8zjjo/Mk4Av66hSPkjcJ49N+VuHmqsVapSmZMML1q5f+LOJuu7n1ly7qpll4OWG6SONyvHxED1 +1vqsG+g==; In-Reply-To: <87tuc2vfa6.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Mar 2022 01:59:13 +0100") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228272 Archived-At: Lars Ingebrigtsen writes: > Hm... it would be nice if it hit the defgeneric instead. But you can > have a defmethod without a defgeneric... Right. To my surprise, it seems there are over 300 such instances of the "without" variant in the Emacs tree. So, currently, we have | defgeneric | defmethod | Old | New | Example | |------------+-----------+-----+-----+--------------------------| | yes | no | g | g | xref-backend-definitions | | no | yes | m | m | delete-instance | | yes | yes | g | m | xref-location-marker | Whereas you're saying we should want | yes | yes | g | g | xref-location-marker | I think simply adding "generic" to this union (: "cl-def" (| "un" "method" "generic")) may do the trick. IOW -cl-\\(?:defun\\|defmethod\\)\\|\ +cl-\\(?:defun\\|defgeneric\\|defmethod\\)\\|\ appears to work in cursory testing. >> P.S. OK to install #53617 duplicate checks in erc--switch-to-buffer? > > Skimming that bug report, it's not clear to me what the issue was there? Just a benign optimization involving some culling of redundant code in `erc--switch-to-buffer'. This email contains the latest version, with a slightly revised commit message: https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-01/msg02081.html Thanks.