From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Tue, 14 Jun 2022 23:00:59 +0530 Message-ID: <87bkuv2lv0.fsf@gmail.com> References: <87fsk72m0b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13648"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 55977@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 19:32:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1AOj-0003Bg-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 19:32:13 +0200 Original-Received: from localhost ([::1]:57122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1AOh-0000rE-Lg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 13:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1AOY-0000qw-AI for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 13:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1AOX-0000Yx-Ty for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 13:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1AOX-0003C9-RR for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 13:32:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87fsk72m0b.fsf@gmail.com> Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55977-submit@debbugs.gnu.org id=B55977.165522787412205 (code B ref 55977); Tue, 14 Jun 2022 17:32:01 +0000 Original-Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 17:31:14 +0000 Original-Received: from localhost ([127.0.0.1]:35662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1ANl-0003An-MV for submit@debbugs.gnu.org; Tue, 14 Jun 2022 13:31:13 -0400 Original-Received: from mail-pj1-f65.google.com ([209.85.216.65]:39728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1ANi-0003AW-5b for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 13:31:12 -0400 Original-Received: by mail-pj1-f65.google.com with SMTP id q12-20020a17090a304c00b001e2d4fb0eb4so12412795pjl.4 for <55977@debbugs.gnu.org>; Tue, 14 Jun 2022 10:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent:mime-version; bh=OTLQ1/G+Ve/3+R5aJh2F4f3gg1HfrhxwcInP6J++Nl4=; b=KJBzHxiw6QY+AFSvn9wB2WsS94HzGXo2MvDnSuqvgJyBIdIwghateE1YOAy1sZKUDC JRESmBU3ODgPGiKfh3nZXOzUrleH/aD/YiJFf/q1QysAWu20RR43+IDxtYwjoBGuNaVl r7F9y03ihjzfnfHjA6FWfoPJDgSPfTbaljBllzwG3ZQqaIsx3ZBYPtgqIaOKXslLxiW0 aUJAga2b8+ccY9mkunq0QRV+05M4I0z0bziRVqzPUONrt1BZ7pIlLqy88OZb4S9jB69q Te2czm3rg/EESmg1YUTkWgGcdASGsuYE0lx3TmB3IVVJ0qKhfuKIwJ+1SDjeHSV827WA ac7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=OTLQ1/G+Ve/3+R5aJh2F4f3gg1HfrhxwcInP6J++Nl4=; b=PqvfGGwVgsxC39lDFHn4i+6dAdHzA/7h/RgYIqYiQCgsoJjqE3dzeohKlCubldLOFw 209C9pWQvJUpMFikO0CWYNwkOA+f7exbFEleCs3m6PJEncC2tBhYAph7aBtiZ2qI51wr G+hZzChlIg77B01urfAiZDd+wgdG3/kdY8pNB6ZqkDA5Ynz6LyZJ4G1dSRsagD1khRoE K4qaFAXwiRh0GShRy9E1XamkD/Il+2s0VTUUCK/YqGrkKFoVzDhl5IqQioGYhyuhVegL kmUZyarFOm3BfOp0zv83kYrshxEXCnFQE46SDkGBNo9sY7b7chr1tUXcocSYaHFxYlCP YE1w== X-Gm-Message-State: AJIora9yKqOzCxjiCLBOkp14mjw45cxTSVy6zrN4f2IXLUXG0IYZLD1N Inc5rEyq9TrKQDVaveJ5fEZdu4DbZ90CwQ== X-Google-Smtp-Source: AGRyM1vA6IohXTmgUEFXj1ScGTIA4hl+K3ibc1n2JU9caUJTALU3Lw4sv4monUxDZVmAbeacvENnNA== X-Received: by 2002:a17:902:ee8d:b0:164:7dd:6cc6 with SMTP id a13-20020a170902ee8d00b0016407dd6cc6mr5865208pld.84.1655227862684; Tue, 14 Jun 2022 10:31:02 -0700 (PDT) Original-Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id g11-20020a17090a708b00b001eabcc229e5sm3138642pjk.51.2022.06.14.10.31.01 for <55977@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:31:01 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234518 Archived-At: --=-=-= Content-Type: text/plain Patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-repeat-mode-Don-t-echo-unset-keys-in-help-message.patch >From 245b353ca178c633c8fffaf0375a9bba99ba1917 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Tue, 14 Jun 2022 22:59:47 +0530 Subject: [PATCH] repeat-mode: Don't echo unset keys in help message * repeat.el (repeat-echo-message-string): Check if the key is set. (bug#55977) --- lisp/repeat.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/repeat.el b/lisp/repeat.el index ea4e3d0bd8..94ea9f7ac1 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -500,7 +500,7 @@ repeat-post-hook (defun repeat-echo-message-string (keymap) "Return a string with a list of repeating keys." (let (keys) - (map-keymap (lambda (key _) (push key keys)) keymap) + (map-keymap (lambda (key cmd) (and cmd (push key keys))) keymap) (format-message "Repeat with %s%s" (mapconcat (lambda (key) (key-description (vector key))) -- 2.35.1 --=-=-=--