From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#56809: file-name-with-extension: Improve docstring. Date: Thu, 28 Jul 2022 10:35:01 +0200 Message-ID: <87bkt98wju.fsf@cassou.me> References: <87edy5929v.fsf@cassou.me> <83ilnhad8j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56809@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 28 11:09:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGzW8-0003o8-2j for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jul 2022 11:09:16 +0200 Original-Received: from localhost ([::1]:38844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGzW6-00022f-Gq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jul 2022 05:09:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyzy-00049Z-Pg for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 04:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGyzy-00030e-Fx for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 04:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGyzy-0005Ch-8X for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 04:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jul 2022 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56809-submit@debbugs.gnu.org id=B56809.165899730619927 (code B ref 56809); Thu, 28 Jul 2022 08:36:02 +0000 Original-Received: (at 56809) by debbugs.gnu.org; 28 Jul 2022 08:35:06 +0000 Original-Received: from localhost ([127.0.0.1]:57539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGyz3-0005BK-PI for submit@debbugs.gnu.org; Thu, 28 Jul 2022 04:35:06 -0400 Original-Received: from mail.choca.pics ([80.67.172.235]:38684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGyz2-0005BC-HO for 56809@debbugs.gnu.org; Thu, 28 Jul 2022 04:35:05 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 0915418192DC8; Thu, 28 Jul 2022 10:35:03 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id EGzqBf-ilafi; Thu, 28 Jul 2022 10:35:02 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 76E6518192DCC; Thu, 28 Jul 2022 10:35:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id wtyzHwAL1ovX; Thu, 28 Jul 2022 10:35:02 +0200 (CEST) Original-Received: from localhost (240-68-190-109.dsl.ovh.fr [109.190.68.240]) by mail.choca.pics (Postfix) with ESMTPSA id 2CEE318192DC8; Thu, 28 Jul 2022 10:35:02 +0200 (CEST) In-Reply-To: <83ilnhad8j.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238083 Archived-At: Eli Zaretskii writes: > Looks OK? looks better than my version :-). The only thing I don't really like is > "Return FILENAME modified to=E2=80=A6 Most readers will know that FILENAME is not going to be modified but the phrasing is still confusing in my opinion. I would prefer a version around the word "concatenate" or similar. Here is another version: Concatenate FILENAME without its extension and EXTENSION. It doesn't say that the result of the concatenation is returned but I'm fine having it implied. Your call. --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill