From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57102: 29.0.50; Peculiar file-name-split edge case Date: Fri, 12 Aug 2022 15:56:02 +0000 Message-ID: <87bkspa225.fsf@posteo.net> References: <87a68cwlnv.fsf@posteo.net> <87y1vtmq4d.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28611"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57102@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 12 18:11:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMXGC-0007Ge-EW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 18:11:44 +0200 Original-Received: from localhost ([::1]:58322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMXGB-0003P2-8I for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 12:11:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMX1y-0004IF-PZ for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 11:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMX1y-0003X1-Fp for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 11:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMX1y-0002zk-C7 for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Aug 2022 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57102 X-GNU-PR-Package: emacs Original-Received: via spool by 57102-submit@debbugs.gnu.org id=B57102.166031977711425 (code B ref 57102); Fri, 12 Aug 2022 15:57:02 +0000 Original-Received: (at 57102) by debbugs.gnu.org; 12 Aug 2022 15:56:17 +0000 Original-Received: from localhost ([127.0.0.1]:58734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMX1F-0002yD-Fx for submit@debbugs.gnu.org; Fri, 12 Aug 2022 11:56:17 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:57091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMX1E-0002y0-3S for 57102@debbugs.gnu.org; Fri, 12 Aug 2022 11:56:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3600D240026 for <57102@debbugs.gnu.org>; Fri, 12 Aug 2022 17:56:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1660319770; bh=mXpNWQLEgIf5Y7ZjK9xXzMBPNA+opbq/YTik+YkSqyM=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Zslp3xEYjEltRcJtPe6zfEksWtSppkm1ferGHA3xsYoTiP+dAp0Tcd58/Kjo9Z+/H 0GLxV9fnqwrsaazektHX6zX7AdztPFhKQeOxkUaJUddmq++VtHfZ6cwf0jJEJd+vtb fR6bcu6MDyYzmiu99N9e4t4BOb79d8SOjvbwz4P7cfef6yVWA2CQhnLaCXIoY8R01z TED2gdN06t0vlpR5shdXmMaKFZlBG/6RlGnmD2VGjxEZUf6KDfQTDxYmgFkv94jtVN dwVYYKhEEXm6H+H94V4s2DPr8QyZHAl7zWiKnjhxAgHjpUwKgKDywpINlF7ur7J0ki 9TK1WOtHNsZ0A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4M47ZJ6qgSz6tmS; Fri, 12 Aug 2022 17:56:08 +0200 (CEST) In-Reply-To: <87y1vtmq4d.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Aug 2022 17:35:30 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239441 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> I am not sure if this is intentional, but the new `file-name-split' >> is a bit unintuitive in this edge-case: >> >> (file-name-split "/") =E2=86=92 ("" "" "") >> >> while >> >> (file-name-split "/a") =E2=86=92 ("" "a") >> (file-name-split "a/") =E2=86=92 ("a" "") >> (file-name-split "a/b") =E2=86=92 ("a" "b") > > The logic is that > > (equal (string-join (file-name-split foo) "/") foo) How sensible is this in the first place? Shouldn't it rather be something like (file-equal-p (apply #'file-name-concat (file-name-split filename)) filenam= e) [ which is currently likewise not given ] Or to put it differently, who does the preceding empty string benefit if we ignore the condition mentioned in the docstring? Are there any real-world use-cases? > is supposed to be always true. I see that's not the case in the "/" > case, so that needs fixing.