From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Wed, 14 Sep 2022 14:37:17 +0000 Message-ID: <87bkriyqci.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> <875yhzl3a1.fsf@posteo.net> <87fsh25bso.fsf@gnus.org> <871qsil3jm.fsf@posteo.net> <87fsgygo7c.fsf@gnus.org> <87a676jfx2.fsf@posteo.net> <87bkrmdt46.fsf@gnus.org> <8735cxpx2r.fsf@posteo.net> <87k066yyn0.fsf@posteo.net> <877d269kgv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57639@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 16:44:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYTco-0005BN-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 16:44:26 +0200 Original-Received: from localhost ([::1]:39890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYTcn-00028M-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 10:44:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYTWe-00054G-J3 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:38:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYTWc-0005sh-Gl for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYTWc-000403-Ae for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166316625015323 (code B ref 57639); Wed, 14 Sep 2022 14:38:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 14 Sep 2022 14:37:30 +0000 Original-Received: from localhost ([127.0.0.1]:55725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYTW5-0003z4-Ve for submit@debbugs.gnu.org; Wed, 14 Sep 2022 10:37:30 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYTW3-0003yj-68 for 57639@debbugs.gnu.org; Wed, 14 Sep 2022 10:37:28 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 44AD8240101 for <57639@debbugs.gnu.org>; Wed, 14 Sep 2022 16:37:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1663166241; bh=rMbg1j46A6RDK2n88iaistTahMcjRN3R80qUMlPRGAE=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=lvUKNGpXcIjCsFCrER1ejfYULQP2mBDPLsNCtum5LwslOYN2JUobAw9dzDe6kefah +KocoQAyvyvCrTfSswyc3tDb3DibBzpPPIXAx4gpAVe9SYbmPxIeIg46zQ6rnjtcpM 8x3ehVXxeUF79jbxIbxqT5s9O47pTNvYtFz8WaKsfwdjY0lLIAG9WDPUsgmJwFDAkQ rWHdJsClZGdFwKNgz3LA37SUQ+qo4N7AETXBZuiPqj+d/DgqmCmdDQ0Y6DSjgxMs8q ETc8cRYLaRAJTPqdg03gpWVDIS9FM232Zh7S/u7w1tTT+GcKpNDqaiiqxs3bX7s4CA 0d+JA12kZW0iw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MSNG83Mc9z6tmq; Wed, 14 Sep 2022 16:37:17 +0200 (CEST) In-Reply-To: <877d269kgv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Sep 2022 15:03:28 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242474 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >>> Here is an updated version: >> >> Any comments on the updated patch? Is it OK to push it in the current >> state or is something missing? > > Well, the current state is with "variants" like > > +(put 'tango 'theme-variants 'tango-dark) ;see `toggle-theme' > > while I wanted to see tagging themes with features instead? That was my question, should variants serve as the foundation for tagging or is tagging an alternative for variants?