From: Uwe Brauer <oub@mat.ucm.es>
To: Po Lu <luangruo@yahoo.com>
Cc: Uwe Brauer <oub@mat.ucm.es>, 58489@debbugs.gnu.org
Subject: bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions
Date: Fri, 14 Oct 2022 09:44:22 +0200 [thread overview]
Message-ID: <87bkqen92h.fsf@mat.ucm.es> (raw)
In-Reply-To: <87edvcyo8i.fsf@mat.ucm.es>
[-- Attachment #1.1: Type: text/plain, Size: 3439 bytes --]
>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
> Uwe Brauer <oub@mat.ucm.es> writes:
>>>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
>>
>>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Then the screenshot with the early-init
>>>
>>> It seems to look ok but when it finishes loading all my init files, it
>>> looks like emacs -Q
>>
>>> Sigh. If you instrument emacsgtkfixed.c as follows:
>>
>>> if (hints->width_inc && data[5] % hints->width_inc)
>>> data[5] += (hints->width_inc - (data[5] % hints->width_inc));
>>> if (hints->height_inc && data[6] % hints->height_inc)
>>> data[6] += (hints->height_inc - (data[6] % hints->height_inc));
>>> (Add instrumentation following this line)
>>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n",
>>> data[5], data[6], hints->width_inc, hints->height_inc)
>>
>>> what is printed when you start Emacs with "-Q", and Kwin shrinks your
>>> window?
>>
>> I don't know anything about that C code (and the last time, I did some C coding is some 10 years ago)
>>
>>
>> Not sure I understand, I apply the patch attached below and run make again:
>>
>> Then I get an error (so most likely I misunderstood you)
>>
>>
>> GEN globals.h
>> CC emacsgtkfixed.o
>> emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>> fprintf (stderr, "XSetWMSizeHints: %l %l width_inc: %l height_inc: %l\n", /* new code for testing */
>> ^
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0x20 in format [-Wformat=]
>> emacsgtkfixed.c:190:21: warning: unknown conversion type character 0xa in format [-Wformat=]
>> emacsgtkfixed.c:190:21: warning: too many arguments for format [-Wformat-extra-args]
>> emacsgtkfixed.c:192:6: error: expected ‘;’ before ‘}’ token
>> }
>> ^
>> Makefile:414: recipe for target 'emacsgtkfixed.o' failed
>> make: *** [emacsgtkfixed.o] Error 1
> Ah, silly me. Please replace %l with %ld.
,----
|
| make
| GEN globals.h
| CC emacsgtkfixed.o
| emacsgtkfixed.c: In function ‘XSetWMSizeHints’:
| emacsgtkfixed.c:190:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int’ [-Wformat=]
| fprintf (stderr, "XSetWMSizeHints: %ld %ld width_inc: %ld height_inc: %ld\n",
| ^
| emacsgtkfixed.c:190:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘int’ [-Wformat=]
| make -C ../admin/charsets all
`----
And
,----
| ./emacs -Q
| XSetWMSizeHints: 297 51 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
|
| (emacs:2027): Gtk-WARNING **: Allocating size to Emacs 0x2be63e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
| XSetWMSizeHints: 414 51 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 85 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
| XSetWMSizeHints: 414 153 width_inc: 9 height_inc: 17
`----
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: emacsgtkfixed-2.patch --]
[-- Type: text/x-diff, Size: 552 bytes --]
diff --git a/src/emacsgtkfixed.c b/src/emacsgtkfixed.c
--- a/src/emacsgtkfixed.c
+++ b/src/emacsgtkfixed.c
@@ -187,7 +187,9 @@
data[5] += (hints->width_inc - (data[5] % hints->width_inc));
if (data[6] % hints->height_inc)
data[6] += (hints->height_inc - (data[6] % hints->height_inc));
- }
+ fprintf (stderr, "XSetWMSizeHints: %ld %ld width_inc: %ld height_inc: %ld\n",
+ data[5], data[6], hints->width_inc, hints->height_inc);
+ }
}
XChangeProperty (d, w, prop, XA_WM_SIZE_HINTS, 32, PropModeReplace,
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]
next prev parent reply other threads:[~2022-10-14 7:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 11:09 bug#58489: 29.0.50; commit 74c07733698b95eb455edcafab8634a700a3194f breaks GTK version for some Ubuntu distributions Uwe Brauer
2022-10-14 2:05 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 5:34 ` Uwe Brauer
2022-10-14 6:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 6:45 ` Uwe Brauer
2022-10-14 7:05 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 7:23 ` Uwe Brauer
2022-10-14 7:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 7:44 ` Uwe Brauer [this message]
2022-10-14 7:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 7:58 ` Uwe Brauer
2022-10-14 8:01 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 7:27 ` Uwe Brauer
2022-10-14 7:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkqen92h.fsf@mat.ucm.es \
--to=oub@mat.ucm.es \
--cc=58489@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).