From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#58985: 29.0.50; Have auth-source-pass behave more like other back ends Date: Sun, 06 Nov 2022 20:59:09 -0800 Message-ID: <87bkpjz7fm.fsf__37034.0101815359$1667797263$gmane$org@neverwas.me> References: <87wn8cb0ym.fsf@neverwas.me> <87y1sow3jk.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9493"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, akib@disroot.org, 58985@debbugs.gnu.org, tino.calancha@gmail.com To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 06:00:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oruFj-0002Ew-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 06:00:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oruFF-0001st-Qj; Mon, 07 Nov 2022 00:00:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oruEz-0001sK-Ii for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 00:00:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oruEs-0006Zo-Rj for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 00:00:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oruEs-000504-Hu for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 00:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2022 05:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58985-submit@debbugs.gnu.org id=B58985.166779716719116 (code B ref 58985); Mon, 07 Nov 2022 05:00:02 +0000 Original-Received: (at 58985) by debbugs.gnu.org; 7 Nov 2022 04:59:27 +0000 Original-Received: from localhost ([127.0.0.1]:32838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oruEJ-0004yG-0X for submit@debbugs.gnu.org; Sun, 06 Nov 2022 23:59:27 -0500 Original-Received: from mail-108-mta52.mxroute.com ([136.175.108.52]:40723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oruEF-0004y0-SN for 58985@debbugs.gnu.org; Sun, 06 Nov 2022 23:59:25 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta52.mxroute.com (ZoneMTA) with ESMTPSA id 1845074f6e40006e99.002 for <58985@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 07 Nov 2022 04:59:13 +0000 X-Zone-Loop: b39d95e930166a0919f2b1da27a56205eb700fac6d1b X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=js8eCXhp1ba0jBzUitcVvO/NSFshUc/r5O9MqIpZbtk=; b=lLTNBLAPS9Fm3IZrWu7lg4X3au wOR0Ck81VzM/f3s8a/GskY19WwFztLS24NpAkxf9CFZC7q7ic2be8mL3/JCyv6wybB/EC/QNuoTRY IzuBeVsU7Q6uJJXLlU6OY7eRyGNI2+51+SQRGQFBcWOnIjW8rZl+3TUwNZDtQbSKLpNs50mBX8nCo TrK5zpPoLsbsCCRms8Lfq2Dy44YQkBdETKkVcfU2W3On0j821pcFF6mwqJeGRIM0Vva8OPW8fnZJO BfT9DsKbLJN7+bnRVSphu2IdzoMdlu3l0ukloAf5TtsOXcboMq+pQve3X+AKDGwak4wy+KsSqw/8Q Xn+VQSkQ==; In-Reply-To: <87y1sow3jk.fsf@cassou.me> (Damien Cassou's message of "Sun, 06 Nov 2022 15:39:11 +0100") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247256 Archived-At: Hi Damien, Damien Cassou writes: > I think it's fine to break backward compatibility if it makes > auth-source-pass closer to what auth-source requires. There's some nice behavior that you introduced initially regarding the narrowing of results, namely (from the info manual): If several entries match, the one matching the most items (where an "item" is one of username, port or host) is preferred. For example ... It'd be a shame to lose that, since folks may have come to rely on it. Perhaps it would be prudent to offer an escape hatch of some sort to restore the existing behavior? > I don't have time to review the code though, I'm sorry. No worries at all. Unfortunately, I don't use pass myself and am mostly concerned with ERC's integration. The good news is an actual pass user, Akib (Cc'd), has expressed some interest regarding this topic on emacs-devel, so I'm hoping they'll step in and take over or collaborate in some fashion. Also, I noticed that the password-store.el in zx2c4's contrib/emacs subdir actually requires auth-source as a dependency, so I've Cc'd the maintainer for that package as well. Thanks, J.P.