From: Philip Kaludercic <philipk@posteo.net>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 58383@debbugs.gnu.org
Subject: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately
Date: Fri, 11 Nov 2022 06:32:06 +0000 [thread overview]
Message-ID: <87bkpexaqh.fsf@posteo.net> (raw)
In-Reply-To: <87pmduwdzs.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 10 Nov 2022 17:07:03 -0700")
Sean Whitton <spwhitton@spwhitton.name> writes:
>>> Typically you wouldn't want to format patches across a merge, so I would
>>> suggest raising an error.
>>
>> And this is something I don't think can be /expressed/ using vc, because
>> while I can collect a number of revisions using `previous-revision',
>> there is no general way to verify if a commit is a merge commit.
>
> Can we do that part on a VCS-by-VCS basis? Default to just calling
> previous-revision and hoping for the best, but giving vc-git.el a chance
> to raise an error.
I guess that would be possible, though it will probably require a new
VC method :/ The new `prepare-patch' takes a revision, so it doesn't
make sense to pass it a number and have it return multiple patches.
Perhaps it will be easier/cleaner to just accept that avoiding merge
revisions is the users responsibility.
But just to have mentioned it: Do you know that you can mark revisions
in log-view and then vc-prepare-patches will use these as the default
input when prompting for revisions?
next prev parent reply other threads:[~2022-11-11 6:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 17:49 bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately Sean Whitton
2022-10-09 12:54 ` Philip Kaludercic
2022-11-04 22:21 ` Philip Kaludercic
2022-11-06 21:44 ` Sean Whitton
2022-11-06 21:49 ` Philip Kaludercic
2022-11-07 23:06 ` Sean Whitton
2022-11-08 20:31 ` Philip Kaludercic
2022-11-08 21:00 ` Sean Whitton
2022-11-09 8:28 ` Philip Kaludercic
2022-11-09 16:36 ` Sean Whitton
2022-11-09 17:46 ` Philip Kaludercic
2022-11-09 20:56 ` Sean Whitton
2022-11-10 20:14 ` Philip Kaludercic
2022-11-11 0:07 ` Sean Whitton
2022-11-11 6:32 ` Philip Kaludercic [this message]
2022-11-11 20:53 ` Sean Whitton
2022-11-13 13:56 ` Philip Kaludercic
2022-11-13 16:06 ` Philip Kaludercic
2022-11-13 16:35 ` Eli Zaretskii
2022-11-13 16:45 ` Philip Kaludercic
2022-11-13 16:52 ` Eli Zaretskii
2022-11-13 18:17 ` Philip Kaludercic
2022-11-14 12:41 ` Eli Zaretskii
2022-11-16 0:04 ` Sean Whitton
2022-11-16 7:50 ` Philip Kaludercic
2022-11-11 7:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkpexaqh.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=58383@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).