From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: eliz@gnu.org, 59338@debbugs.gnu.org, arash@gnu.org
Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
Date: Thu, 17 Nov 2022 17:27:40 -0500 [thread overview]
Message-ID: <87bkp5xl6f.fsf@dfreeman.email> (raw)
In-Reply-To: <87o7t5wlby.fsf@gmail.com>
Augusto Stoffel <arstoffel@gmail.com> writes:
> On Thu, 17 Nov 2022 at 19:06, Eli Zaretskii wrote:
>
>> Both are wrong, right? The correct URL should AFAIU be
>>
>> file:///d:/digestif-test/tikz-test.tex
>>
>> IOW, the problem is that the URL is being run through url-encode-url,
>> which doesn't support file:// URLs on Windows properly.
>
> While we are at it, note that
>
> (url-filename
> (url-generic-parse-url "file:///d:/digestif-test/tikz-test.tex"))
> => "/d:/digestif-test/tikz-test.tex"
>
> is not the right file name under Windows. Eglot treats this special
> case correctly, but every package that deals with file URLs has to
> repeat the work. So there should be a helper function in Emacs for
> this.
With the original problem: we're now getting a false positive in
eglot when checking for URLs being passed to `eglot--path-to-uri` when
the path is a windows path.
Is there something we can do to detect a windows path and continue
treating it as a path like we were before this change?
```
(defun eglot--path-to-uri (path)
"URIfy PATH."
(let ((truepath (file-truename path)))
(if (and (url-type (url-generic-parse-url truepath))
(NOT_WINDOWS_PATH truepath) ;; what would this be?
)
;; ... blah blah blah
```
If there is no function available already, it may be enough to check if
the return value of `url-type` is not 1 character. Looking at this list
of what I believe are official URI schemes, all of them have at least
two characters:
https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
--
Danny Freeman
next prev parent reply other threads:[~2022-11-17 22:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 16:51 bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Arash Esbati
2022-11-17 17:06 ` Eli Zaretskii
2022-11-17 17:18 ` Augusto Stoffel
2022-11-17 22:27 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-17 23:12 ` Augusto Stoffel
2022-11-18 7:14 ` Eli Zaretskii
2022-11-18 13:39 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 14:35 ` Eli Zaretskii
2022-11-18 14:55 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 20:01 ` Arash Esbati
2022-11-18 7:12 ` Eli Zaretskii
2022-11-23 12:51 ` João Távora
2022-11-24 13:42 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24 15:27 ` João Távora
2022-11-17 22:33 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkp5xl6f.fsf@dfreeman.email \
--to=bug-gnu-emacs@gnu.org \
--cc=59338@debbugs.gnu.org \
--cc=arash@gnu.org \
--cc=arstoffel@gmail.com \
--cc=danny@dfreeman.email \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).