unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60399-done@debbugs.gnu.org, juri@linkov.net
Subject: bug#60399: 30.0.50; Usage of `isearch-open-invisible-temporary' is not documented
Date: Sun, 01 Jan 2023 12:51:40 +0000	[thread overview]
Message-ID: <87bkni8lk3.fsf@localhost> (raw)
In-Reply-To: <83wn6634gb.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> What about the manual?
>> (elisp) 41.6 Invisible Text
>
> I don't think this obscure issue needs to be mentioned in the manual.
> It is quite clear to me that the overlay in question cannot be
> deleted, I actually raised a brow when you asked for this to be
> explicitly mentioned.

I think I need to explain the context a bit.

In org-fold, we want isearch matched to be not just revealed according
to the full overlays they are hidden in. We want to rearrange the
overlays in such a way that outline structure above the match is
revealed:

* Folded heading
** Folded sub-heading
Some unrelated text.
:FOLDED-DRAWER:
isearch-match
:END:

which will look like

* Folded heading...

When we do isearch, the aim is

* Folded heading
** Folded sub-heading...
isearch-match
...

which requires re-creating overlays used for folding.

In the process, 'isearch-open-invisible-temporary may affect more than
the overlay used as its argument. In particular, other overlays at point
may be affected.

The 'isearch-open-invisible-temporary takes care about proper saving and
restoring the necessary overlays. However, isearch gets broken.

In this setup, it is not that obvious that isearch will still try to do
something with overlays that got deleted during the call to
'isearch-open-invisible-temporary.

I am not even sure how to achieve the desired custom behavior using the
current isearch implementation.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





  reply	other threads:[~2023-01-01 12:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 10:10 bug#60399: 30.0.50; Usage of `isearch-open-invisible-temporary' is not documented Ihor Radchenko
2022-12-29 17:33 ` Juri Linkov
2022-12-31 13:03   ` Ihor Radchenko
2023-01-01  9:05     ` Eli Zaretskii
2023-01-01  9:09       ` Ihor Radchenko
2023-01-01 11:00         ` Eli Zaretskii
2023-01-01 12:51           ` Ihor Radchenko [this message]
2023-01-01 13:55             ` Eli Zaretskii
2023-01-02  8:57               ` Ihor Radchenko
2023-01-02 12:29                 ` Eli Zaretskii
2023-01-02 15:34             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-03  9:02               ` Ihor Radchenko
2023-01-03 14:14                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkni8lk3.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=60399-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).