From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60503: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes Date: Mon, 02 Jan 2023 21:57:47 +0100 Message-ID: <87bkng7iyc.fsf@thornhill.no> References: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24698"; mail-complaints-to="usenet@ciao.gmane.io" To: jostein@kjonigsen.net, 60503@debbugs.gnu.org, casouri@gmail.com, dancol@dancol.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 21:58:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCRt4-0006Ee-7e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 21:58:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCRsh-0002lE-BJ; Mon, 02 Jan 2023 15:58:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRsg-0002ky-4e for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCRsf-0008EW-TF for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCRsf-0003bM-PG for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 20:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: jostein@kjonigsen.net, "bug-gnu-emacs@gnu.org" , Yuan Fu , Daniel Colascione Original-Received: via spool by submit@debbugs.gnu.org id=B.167269307913835 (code B ref -1); Mon, 02 Jan 2023 20:58:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jan 2023 20:57:59 +0000 Original-Received: from localhost ([127.0.0.1]:44210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRsc-0003b5-TH for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:57:59 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:35604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRsb-0003aw-FS for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:57:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRsb-0002kh-9o for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:57:57 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRsZ-0008EF-6G for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:57:57 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672693069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iO1It+un+2ji8ZhHfJczzIslyy4KytbIBdi/t0oI9kk=; b=Q1+ePJqXDnnpdR56+z+iDRp2tfmNX8fHTkku4WBm3yWxsNfC4eCBRrq9vEVRPVRlI1jBwd 3qMiuuKMkqonPMvwYYJry6MdSIkZbjuchXMWkF8LDZf2jNA+ClT2yuRG4E/D6WQiqGtp0v edIUwUKCXxmkWE35eENGtQcte3J6Ut2S3Px3Ery3IC6/Yoeon8Ay9bjv8z4EfwDRDiEtG0 /yGJdyYe74M/6J5ludFzIRJ9HLthi1QLJGcaHfGiybHIMNn9n4Oiy4KAe2iwP3ivO+Ua5R Dx7eOl6+X2T/Wh7U/bqdOc3Ph3XEpUS34MBDQpaDSusit0El1emEQ5q+Gd8+YQ== In-Reply-To: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=188.165.223.204; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252364 Archived-At: Jostein Kj=C3=B8nigsen writes: > js-ts-mode does not adhere to the "standardized" features and=20 > fontification levels requested in emacs-devel. > > It's overall pretty good, but I did find one minor inconsistency which=20 > annoyed me enough to (IMO) warrant an update: > > js-ts-mode does not highlight incoming parameters in=20 > functions/methods/arrow-expressions as variables. > > Attached is a patch which fixes this issue and makes it much more=20 > consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode. > Looks good to me :-) Theo