From: Mekeor Melire <mekeor@posteo.de>
To: "João Távora" <joaotavora@gmail.com>
Cc: 62687@debbugs.gnu.org
Subject: bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc
Date: Sat, 08 Apr 2023 20:44:08 +0000 [thread overview]
Message-ID: <87bkjym6ic.fsf@posteo.de> (raw)
In-Reply-To: <87cz4egnqa.fsf@gmail.com>
2023-04-08 20:47 joaotavora@gmail.com:
> Mekeor Melire <mekeor@posteo.de> writes:
>
> > The main issue is that Eglot won't show the
> > "SignatureInformation"'s "documentation" field if it is of
> > type MarkupContent.
>
> OK I see it, I understand it, and I've done some changes to
> master. Please have a look at commit
> 685435cb52eaa6f61b7088398f1f53e69d76e63e.
Thank you! That commit indeed makes Eglot show
"SignatureInformation"'s "documentation" field even if it's of
type MarkupContent. So it solves this main issue.
Unfortunately, that commit causes Eglot to not show the
"ParameterInformation"'s "documenation" field. I propose to show
both the SigInfo- and the ParamInfo-documentation, whenever
possible. (To be more precise: First, the SigInfo-doc should be
shown, if non-nil. Then, the ParamInfo-doc should be shown, if
non-nil.) What do you think?
Would you like to have an audio-call to talk about the problems
related to `eglot--sig-info'? I think it would be much more
efficient than email.
next prev parent reply other threads:[~2023-04-08 20:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 21:17 bug#62687: 30.0.50; Eglot (eglot--sig-info): SignatureInformation's Documentation is never shown when it's of type MarkupContent Mekeor Melire
2023-04-06 19:21 ` Mekeor Melire
2023-04-06 19:49 ` Mekeor Melire
2023-04-06 20:34 ` Mekeor Melire
2023-04-07 22:40 ` bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc Mekeor Melire
2023-04-07 23:49 ` João Távora
2023-04-07 23:53 ` João Távora
2023-04-08 14:35 ` Mekeor Melire
2023-04-08 19:47 ` João Távora
2023-04-08 20:44 ` Mekeor Melire [this message]
2023-04-08 21:12 ` João Távora
2023-04-08 22:31 ` João Távora
2023-04-09 21:46 ` Mekeor Melire
2023-04-10 7:14 ` João Távora
2023-04-10 20:02 ` Mekeor Melire
2023-04-11 11:16 ` João Távora
2023-04-11 11:47 ` Mekeor Melire
2023-04-11 12:56 ` João Távora
2023-04-11 13:53 ` João Távora
2023-04-11 13:59 ` Eli Zaretskii
2023-04-09 22:14 ` Mekeor Melire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkjym6ic.fsf@posteo.de \
--to=mekeor@posteo.de \
--cc=62687@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).