From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#63676: cancelling editable dired causes UI problems with dired Date: Mon, 29 May 2023 03:35:40 +0200 Message-ID: <87bki36hsj.fsf@web.de> References: <83ilcing54.fsf@gnu.org> <87jzwupp7n.fsf@web.de> <83edn2jnqd.fsf@gnu.org> <87r0r15dl5.fsf@web.de> <83ilcdhs6m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: peter.mao@gmail.com, 63676@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 03:36:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3RoA-0006D0-6N for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 03:36:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3Rno-0001C5-NH; Sun, 28 May 2023 21:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3Rnm-0001Br-TA for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 21:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3Rnm-0002AM-KZ for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 21:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3Rnm-0001T2-Eh for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 21:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 01:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63676 X-GNU-PR-Package: emacs Original-Received: via spool by 63676-submit@debbugs.gnu.org id=B63676.16853241485618 (code B ref 63676); Mon, 29 May 2023 01:36:02 +0000 Original-Received: (at 63676) by debbugs.gnu.org; 29 May 2023 01:35:48 +0000 Original-Received: from localhost ([127.0.0.1]:56702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3RnY-0001SY-GK for submit@debbugs.gnu.org; Sun, 28 May 2023 21:35:48 -0400 Original-Received: from mout.web.de ([217.72.192.78]:36925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3RnX-0001SL-6p for 63676@debbugs.gnu.org; Sun, 28 May 2023 21:35:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1685324141; i=michael_heerdegen@web.de; bh=VMIKOKh05ApXbYVBGvAaDJFmn6tdmTHd2URX4eTkmbg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Abj5lUhZsIEStLmhNdlfdGbtG1DOH32KbGWwFiM3gskI8G/LslhMx7dMuyych9khP ske5/YTsJ3eGz8nlgfroKwVbpyBQa1B2NVNkAPbx/IBqLnaNUkqnLhOJqgskLnH/di zqTgwYBMmenzJuiX8UO+KEc8XQQ/cvAIUnJ4Otnux3bUrbrBg1jIH0dt8HXagRUq4E fYXCFXT0DnO8ibgYr0VIG3hKzj1HKG/0W7u2l20I9exOiY2ectZBSyaofFkS83x4Ap /MIxDH8UGzI/y+9e2lIIWkurcJ75hncN9qneaVhHVpo21206yseA89rLqO65SSXArG ZoflVbVPt7/xQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N1LwP-1qFWQJ3Ytf-012t62; Mon, 29 May 2023 03:35:40 +0200 In-Reply-To: <83ilcdhs6m.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 28 May 2023 09:43:29 +0300") X-Provags-ID: V03:K1:sqRW+RK9PtMa4qZ+G4VnMy3OxDJ6j6OCyTh5MIN+UpAnQhWqrGu oZ60Bjpb1XG4hmjG2iGqGU4ceA8oGaGr6cpfXs7yzsM36HKmqQ+eW5Itd12DlVWcxwlfFow sxIowqI18E9/xWT8U9yFIzIpbTZtGVK8l7RGm8ejmu3u/1nZU9XaCfrpa3cIeJ7Kc1oIWh4 LFW7/NWGSwueK0oAzgUxw== UI-OutboundReport: notjunk:1;M01:P0:ehgUH8vOxy4=;xKYJ8GZnvUUGCxhF+cy1zunqxP8 pWfpuk5LFr7AORRBHA4xJBAvSCEZ9IdLeSRh/M1oNCYc43iHt2gr8dzNgoL3b/ObOIScII6E5 z0alxP6ERWgos2W8+mtGnBtHSiNPoPtdRIfmI8O4wgymnV0xneeRMmnWeQyAxfhTbk0TyaWv5 /30k+G3KeT16urEkARXBTBGEU4rm8KvLE82NxX7rwJhwSCmvUxN7LVyn/YPrbgQZsZ+DL/7Y1 AZMya2ssBbLV0s3uG8VlOvO0kFwN3UpZFGWbN1V5Bh3gIkTb+0UImlcC6FkW0Bgp7gMqN4nD2 uxwa0oYkAd+ZnkdGfzo//MSRq/aRcPPcA4hKP5mevwhb+7DS8DAJxWYYWoFyv/DT6IOwygyet ae8E0of16CxwtDVor2xRkPgPl2yPN5c49gQChdwV6/vcTJ3O/K5jnGlC3IKD19EIhpvcZOChQ If//WsV/Rxv7OjIDqeR5fDGbCjgKvmEDhGAufRjgHl5bpsxrplwEp/y9TZVAY0rnrrOBrJ52R HGIsYYKoPhnKK00Ul0zpZA+TT2DlEQAJvdYb9CIkbFBi+Fyem+AL7ZmLCWO9ol9VAr4xmDEpH jQHt6m/ZUtSHPZOXyBzkJsQRj34OhZxg8jP9z88M/7O1zBNJPF1IAqbfXvbgNnl0XNsl8ynzR YRklacO99HQ+K3+nB6/wNXFMX1/QDwKiABnYXcpSeACHPaNvs66CnDEgeDwlCZWgx2w3EU7Xa EuZ3Tn45Sp0n0yKNG7430cMjD9coZhLGJJyfB79i0ez29hP6w8opLvwftC9/a3xLsilJ5tCA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262555 Archived-At: Eli Zaretskii writes: > Thanks, so I've now installed your change on the emacs-29 branch Thanks. > (and will hold you responsible for any breakage that causes ;-). Of course! A breakage would hurt more than the responsibility. Jokes aside: Calling `dired-build-subdir-alist' here should be save: `dired-undo' also calls it when a user undoes mark changes (so it's not only called after reading in a fresh buffer), it should be "normal business" (and the right fix). Michael.