From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: No Wayman Newsgroups: gmane.emacs.bugs Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Tue, 04 Jul 2023 18:21:00 -0400 Message-ID: <87bkgr48qy.fsf@gmail.com> References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20921"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.7; emacs 30.0.50 Cc: 64452@debbugs.gnu.org, Andrea Corallo , Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 05 00:23:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGoQU-0005F5-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jul 2023 00:23:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGoQK-00087w-9J; Tue, 04 Jul 2023 18:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGoQI-00087n-Ve for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 18:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGoQI-00033n-KP for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 18:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGoQI-0004XE-5s for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 18:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: No Wayman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2023 22:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64452-submit@debbugs.gnu.org id=B64452.168850936917398 (code B ref 64452); Tue, 04 Jul 2023 22:23:02 +0000 Original-Received: (at 64452) by debbugs.gnu.org; 4 Jul 2023 22:22:49 +0000 Original-Received: from localhost ([127.0.0.1]:36747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGoQ5-0004WY-EK for submit@debbugs.gnu.org; Tue, 04 Jul 2023 18:22:49 -0400 Original-Received: from mail-qk1-f171.google.com ([209.85.222.171]:44245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGoQ2-0004WI-Ef for 64452@debbugs.gnu.org; Tue, 04 Jul 2023 18:22:47 -0400 Original-Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-765a6bbddd6so512036985a.0 for <64452@debbugs.gnu.org>; Tue, 04 Jul 2023 15:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688509360; x=1691101360; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=txALNBnlafB4RXbni8ws/KMpwGfcjlSJXjSQnBuz7jM=; b=RYg5/6RWrT7lvrY6BpG6lmBD4yr+lrKB98+9+DvUVUbxeyAyDP4dWys1sFT1OjhZsO YV7M6ldJaYr66bc29YrgRDfFeU8cp1iqpZwYVp+PpmT3DueFMpLP13RM3wCezh4MJsWj cSvrQc3uTaX18Vcwrn+cYXak3VAe0FNbw67QtKX+IGN7xlwc9ZnQvLt9WuWP4x5Z+3p+ J+lUBulrj6EG5E3quBMYxZopjt9/5Muq38TVE4WZ/gYp/ezbZ8AOsQHC1GhHHewi2bL5 0jYRGWOxX9ArK+Z0lBv4vxmxDXS0n7c+1hhd0hCxN3SfVnjDljb/jpTjtGQQDlq/oVJL /EHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688509360; x=1691101360; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=txALNBnlafB4RXbni8ws/KMpwGfcjlSJXjSQnBuz7jM=; b=lvQIDmDVl6XxVOnaR5g7ByN13gXjI/eiDMpYUocDOXwmSv+kIVEu5Snor3JYfo3Pfg vQ2EFrMIacy5J4eVXPSICf0o7E97R/mmLPLazK9fFLAABXU5uCNHSu7vJvk0UvVgJ6Tu QABpZyzKFancrmADK1Lp3cyUXFI5Fiunuh9pvKmGI7LzY5QbJ+EXmv2Uo0JPSTyXqtiT uVck2upGg7L1mQgIMXi3zNsZegFmpodBT1rhi3+oBQq3Z2BDGhmfLkN58TVooTAvumZI J+5A2iQ4ZkT5ZnBopv1t3ogFDbaiGncWbGHXserM4xihDDtI/sDOxU1Q3ylWDPZ1JCJE PrcA== X-Gm-Message-State: AC+VfDx0jZqPeghL1xWoxgt7kGdVhtukznAMXpBmmRusALwoIISjxV1u fgW9rwX9FhRxPdURW/toOmY6bfoyYrkfmhYY X-Google-Smtp-Source: ACHHUZ7rwulBjmgJ6LkFkNPN14fotySrHBvGCG+80NQgLHnQLIR0BzwrcWqC16n8WhJhYzGgbAdL6w== X-Received: by 2002:a05:620a:404e:b0:767:3cfa:dc0f with SMTP id i14-20020a05620a404e00b007673cfadc0fmr15972631qko.25.1688509360284; Tue, 04 Jul 2023 15:22:40 -0700 (PDT) Original-Received: from laptop ([2601:84:847f:c697:2d4:9eff:feb6:970c]) by smtp.gmail.com with ESMTPSA id x10-20020ae9f80a000000b007676658e369sm3152696qkh.26.2023.07.04.15.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 15:22:39 -0700 (PDT) In-reply-to: <83zg4ckki0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264608 Archived-At: --=-=-= Content-Type: text/plain; format=flowed Eli Zaretskii writes: > Thanks, but why not elisp-compile-mode, like we do in > *Compile-log* > buffers for byte compilation? Works for me. Revision attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-comp.el-use-emacs-lisp-compilation-mode-for-log-buff.patch >From 9912e598354f877cb4ccf20ac68d7267d8c599c8 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Mon, 3 Jul 2023 20:23:00 -0400 Subject: [PATCH] * comp.el: use emacs-lisp-compilation-mode for log buffers (comp-log-to-buffer): ensure comp-log-buffer in emacs-lisp-compilation-mode (comp-run-async-workers): ensure comp-async-buffer in emacs-lisp-compilation-mode --- lisp/emacs-lisp/comp.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 22fb08e4688..5f42d10407f 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1133,7 +1133,8 @@ comp-log-to-buffer (log-buffer (or (get-buffer comp-log-buffer-name) (with-current-buffer (get-buffer-create comp-log-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'emacs-lisp-compilation-mode) + (emacs-lisp-compilation-mode)) (current-buffer)))) (log-window (get-buffer-window log-buffer)) (inhibit-read-only t) @@ -4085,7 +4086,8 @@ comp-run-async-workers :buffer (with-current-buffer (get-buffer-create comp-async-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'emacs-lisp-compilation-mode) + (emacs-lisp-compilation-mode)) (current-buffer)) :command (list (expand-file-name invocation-name @@ -4119,6 +4121,8 @@ comp-run-async-workers (run-hooks 'native-comp-async-all-done-hook) (with-current-buffer (get-buffer-create comp-async-buffer-name) (save-excursion + (unless (derived-mode-p 'emacs-lisp-compilation-mode) + (emacs-lisp-compilation-mode)) (let ((inhibit-read-only t)) (goto-char (point-max)) (insert "Compilation finished.\n")))) -- 2.41.0 --=-=-=--