From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63800: 30.0.50; [ELPA] Inaccurate installation instructions for built-in packages Date: Wed, 12 Jul 2023 07:46:07 +0000 Message-ID: <87bkgh608w.fsf@posteo.net> References: <87mt1mi6ry.fsf@localhost> <87y1l5q9p9.fsf@posteo.net> <875y89t2a1.fsf@localhost> <87r0qdxnvh.fsf@localhost> <12eb3b7e-f944-6a96-cfb9-285891d659ca@gutov.dev> <87bkgl8fei.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 63800@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 12 09:47:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJUZD-0000y8-OA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jul 2023 09:47:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJUZ0-00043p-Nh; Wed, 12 Jul 2023 03:47:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJUYx-00043X-ED for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 03:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJUYw-0002Cq-7l for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 03:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJUYv-0004Un-M7 for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 03:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jul 2023 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63800 X-GNU-PR-Package: emacs Original-Received: via spool by 63800-submit@debbugs.gnu.org id=B63800.168914798517239 (code B ref 63800); Wed, 12 Jul 2023 07:47:01 +0000 Original-Received: (at 63800) by debbugs.gnu.org; 12 Jul 2023 07:46:25 +0000 Original-Received: from localhost ([127.0.0.1]:51628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJUYK-0004Tz-LV for submit@debbugs.gnu.org; Wed, 12 Jul 2023 03:46:25 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:45751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJUYB-0004Te-M9 for 63800@debbugs.gnu.org; Wed, 12 Jul 2023 03:46:23 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9EB6F240027 for <63800@debbugs.gnu.org>; Wed, 12 Jul 2023 09:46:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689147969; bh=uuXEaCEWKiJhDAXnN+6xuGNhJj6R6P/VtRmXS5CSHbY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=heGXgE23fSt0zMDhvjZ93WVVlJuqRbYgeUCOLvtSQBib9CDu9r7YKRXBBhnjil5fj /H7LCFUgY+ESq9p3dlB+86tIyc4iDBalDc7RdRtmzWgSzv8qOlFiCb3ryLploZCLUH 1fp8VcXZBBx6R/18pfEwXWI1L+OwfBUS5U0ZGYGGDK+ac0uJmjhDza9/EipDLOjHyI kygK1UoKQBIgPWrgTcoqp1P6H0zufUYcju0aBOt5To4iH5n4CqKqRTR5pEJtyoY8t2 nQ1aqvmRck3xYJmWlY5feBPJWegMiFGFcp2PKaiprjpiyitbVdtWQjYXpSU4t/XIrV +AIZPVy/3V9xQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R18tn0l25z6txJ; Wed, 12 Jul 2023 09:46:08 +0200 (CEST) In-Reply-To: <87bkgl8fei.fsf@localhost> (Ihor Radchenko's message of "Sun, 09 Jul 2023 11:59:01 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264955 Archived-At: Ihor Radchenko writes: > Dmitry Gutov writes: > >> Perhaps a simpler alternative is to stop referencing 'package-install' >> and instead point uses to 'M-x list-packages'. > > See the attached patch. Looks good, just one nitpick: > From e3e7eae381c0756b54935121c3f0a641685af666 Mon Sep 17 00:00:00 2001 > Message-ID: > From: Ihor Radchenko > Date: Sun, 9 Jul 2023 14:56:22 +0300 > Subject: [PATCH] Suggest `package-install' to install packages > > * elpa-admin.el (elpaa--html-make-pkg): Instruct using `list-packages' > to install packages instead of `package-install'. > > See bug#63800. > --- > elpa-admin.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/elpa-admin.el b/elpa-admin.el > index 7ee385d0a..2b5c9b3dd 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -1879,7 +1879,8 @@ (defun elpaa--html-make-pkg (pkg pkg-spec files srcdir plain-readme) > (elpaa--html-insert-docs pkg-spec) > (insert "") > (insert (format "

To install this package, run in Emacs:

> - 
M-x package-install RET %s RET
" > + 
M-x list-packages RET
> +

Then, find %s in the list, click on the link, and click Install.

" Are you sure that "Install" should have the class kw (I assume keyword)? > name)) > (let* ((readme-content (elpaa--get-README pkg-spec srcdir)) > (readme-text plain-readme) > -- > 2.41.0 Other than that, can you push the commit or should I do it?