unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	64809@debbugs.gnu.org, David Fiander <david@fiander.info>
Subject: bug#64809: 29.1; Initial frame is wrong size when dimensions specified in init file
Date: Tue, 25 Jul 2023 10:08:25 +0800	[thread overview]
Message-ID: <87bkg0zqsm.fsf@yahoo.com> (raw)
In-Reply-To: <8b0befa5-37df-6c92-b3d9-11dee0bc27ea@gmail.com> (Jim Porter's message of "Mon, 24 Jul 2023 18:14:55 -0700")

Jim Porter <jporterbugs@gmail.com> writes:

> In my case, it seems that the only thing that's changed inside
> 'apply_xfg_settings' is the hint style. If I comment out the hint
> style block, everything works correctly.
>
> However, that did lead me to debug further, and I think the issue
> really lies elsewhere; the commit I mentioned (likely) just uncovered
> a latent bug. Starting from "emacs -Q", I eval the following (after
> the frame is all set up, of course):
>
>   (set-face-attribute 'default (selected-frame) :height 70)
>   ;; The frame and default face both shrink as expected.
>   (reconsider-frame-fonts (selected-frame))
>   ;; The frame and default face now revert to their old sizes.
>
> Is this behavior correct? I'd expect that 'reconsider-frame-fonts'
> would take my setting from 'set-face-attribute' into consideration,
> but it seems to throw it out.

Ugh.  No, I didn't intend for `reconsider-frame-fonts' to behave in this
manner.  I can't help wondering why this wasn't caught until the release
candidate of all things.

ISTM that more attributes of the default face should also be preserved
whenever its definition is merged into a frame and used in
`default_font_parameter'.





  reply	other threads:[~2023-07-25  2:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-23 20:02 bug#64809: 29.1; Initial frame is wrong size when dimensions specified in init file David Fiander
2023-07-24 11:27 ` Eli Zaretskii
2023-07-24 12:05   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-24 13:15     ` David Fiander
2023-07-24 13:27       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-24 13:55         ` David Fiander
2023-07-24 23:50           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-24 16:33         ` Jim Porter
2023-07-24 20:53           ` Jim Porter
2023-07-25  0:09             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-25  0:36               ` David Fiander
2023-07-25  1:14               ` Jim Porter
2023-07-25  2:08                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-07-25 11:56                   ` Eli Zaretskii
2023-07-25 15:42                     ` Jim Porter
2023-07-25 16:27                       ` David Fiander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkg0zqsm.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=64809@debbugs.gnu.org \
    --cc=david@fiander.info \
    --cc=eliz@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).