Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org >> Date: Thu, 03 Aug 2023 18:51:28 +0200 >> >> Eli Zaretskii writes: >> >> >> +(defun image-dired-update-thumbnail-at-point () >> >> + "Update the thumbnail at point if the original image file has been >> >> +modified. Take care of uncaching and removing the old thumbnail >> >> +file." >> > >> > The first line of the doc string should be a single complete sentence. >> > (Just move the "modified" part to the first line, I think there's >> > enough space there.) >> >> I don't understand. "Update the thumbnail at point." does not seem >> sufficient because the fact that the original image might be modified is >> the main point of this function. > > What I had in mind is this: > > (defun image-dired-update-thumbnail-at-point () > "Update the thumbnail at point if the original image file has been modified. > This function uncaches and removes the thumbnail file under the old name." > > OK? Ok. Sorry I misread your reply ("move" not "remove"). BTW, I'm using 'M-q' on docstring and my fill-column is set to 70 (the default I guess): is there a better way? >> What about: >> >> "When 'image-dired-thumb-naming' is set to 'sha1-contents', 'thumb' and >> 'old-thumb' could be different file names. Update the thumbnail then." > > Much better, thanks. Ok, so here is a new patch.