From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49407: Request: Specify default values in `map-let` in Map.el Date: Tue, 08 Aug 2023 14:41:28 +0200 Message-ID: <87bkfhk8p3.fsf@epfl.ch> References: <87eec0klhu.fsf@gnus.org> <08a00b74-56f9-bb81-0411-36f9da8cf2d6@protonmail.com> <87r0p0wwbw.fsf@web.de> <87pm4fbapu.fsf@web.de> <87jzujoqxr.fsf@epfl.ch> <87fs55h5f3.fsf@epfl.ch> <87cz08wwxk.fsf@web.de> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20797"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Okam , Lars Ingebrigtsen , 49407@debbugs.gnu.org, Nicolas Petton , Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 14:42:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTM2T-0005D1-Gj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 14:42:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTM2J-00048Y-1y; Tue, 08 Aug 2023 08:42:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTM2G-00047m-EX for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 08:42:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTM2E-00053a-8O for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 08:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTM2E-0007PA-4I for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 08:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49407 X-GNU-PR-Package: emacs Original-Received: via spool by 49407-submit@debbugs.gnu.org id=B49407.169149849928434 (code B ref 49407); Tue, 08 Aug 2023 12:42:02 +0000 Original-Received: (at 49407) by debbugs.gnu.org; 8 Aug 2023 12:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:35496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTM1r-0007OY-F0 for submit@debbugs.gnu.org; Tue, 08 Aug 2023 08:41:39 -0400 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:48397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTM1p-0007OE-8T for 49407@debbugs.gnu.org; Tue, 08 Aug 2023 08:41:38 -0400 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9b904bb04so91080221fa.1 for <49407@debbugs.gnu.org>; Tue, 08 Aug 2023 05:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1691498491; x=1692103291; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yulN9ii0ooit0/PQOnmWmXrkyrf9MDAqHsCt6q0AuUw=; b=TFugMH6XZGICi5vVvWHT3Vn2hpwx3sG0SMm+UQOh3AQawJc0h+te3y1QNwaXqzKEd4 GUdw/2W1z3pmHFENb0Bja2l1OO7MGFKftLmglb2kVXAKxhIIVqJGJ1me0UgAOAazKsyv HZ1sKmP7rpNKWqi6xjVQKd0uo55lJDLFJYdnqGq0z7msO6H+8Yqsbh3znZ2MBkibcpjF /oMNu7hI2JA1vSeLBYIY9E+iK5rvj9HlDxvVG9+2HaB4bGOfRF4EL7gOmbCBkSNTnNeh 2SS7trnKTsO+c4GhZXX+hAm5dBD/KtnvCFdXv1NL4Ihc7yUcexeCWmO198NY8S02/1mc qALQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691498491; x=1692103291; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yulN9ii0ooit0/PQOnmWmXrkyrf9MDAqHsCt6q0AuUw=; b=Xi7h3pGTbWJumFhoGat4/esg4xWJlSnh4PyIbgSLrf7coN5qTvq39Mb1kgjIK2fBiQ Dwng0MzjWyuwnRWQhtFCHypUhLe32zYSyDLlohaZzuU0mrD8jYajJn5WFfa7/JrAe6h1 BoNfv0aYFq1/moTBjwQ3Aj/To1lJx84MrgcClSOpHCQFRLJrcHxow3e+e/BbYDpmR03s NHoXcjPrQDn0/p2NikGl+fGbNua9rlJrCyKy/iBqpK8ysI4I0/RWf0FxhHnBQKmI1+vV EvhAEaIvEfAcpz+obyON8VGyPU/yM/85jWNiX8KmbgI+esf3phFlQj8dIUB0OzS8yKur GIEg== X-Gm-Message-State: AOJu0YwWSWjatOvagYEQl1CBBbWlRBJlhe5twxQ10+7b0bwCxeAoYkVm /5aOay4h/Er4oDrZYrGWZsBQ9A== X-Google-Smtp-Source: AGHT+IFyyixlHmiNGngtjN0KMoMRjS/e0qMVh3QklQ7Zu/goNNmUnesNjLoB+eoJaqo6fDGw8ygLmg== X-Received: by 2002:a2e:3011:0:b0:2b6:fa60:85a1 with SMTP id w17-20020a2e3011000000b002b6fa6085a1mr8637285ljw.21.1691498491083; Tue, 08 Aug 2023 05:41:31 -0700 (PDT) Original-Received: from localhost ([89.19.67.19]) by smtp.gmail.com with ESMTPSA id c5-20020a05600c0ac500b003fc02218d6csm17939493wmr.25.2023.08.08.05.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 05:41:30 -0700 (PDT) In-Reply-To: <87cz08wwxk.fsf@web.de> (Michael Heerdegen's message of "Mon, 31 Jul 2023 06:02:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266949 Archived-At: Michael Heerdegen [2023-07-31 06:02 +0200] wrote: > Does this addition look appropriate? Reads fine to me, so AFAIC feel free to install. Just a couple of thoughts inline: > diff --git a/lisp/emacs-lisp/map.el b/lisp/emacs-lisp/map.el > index b55eb431668..04c00a2e908 100644 > --- a/lisp/emacs-lisp/map.el > +++ b/lisp/emacs-lisp/map.el > @@ -57,9 +57,10 @@ map > defaults to nil. Both KEY and DEFAULT are evaluated. > > Each element can also be a SYMBOL, which is an abbreviation of > -a (KEY PAT) tuple of the form (\\='SYMBOL SYMBOL). When SYMBOL > -is a keyword, it is an abbreviation of the form (:SYMBOL SYMBOL), > -useful for binding plist values. > +a (KEY PAT) tuple of the form (\\='SYMBOL SYMBOL). A keyword :FOO > +is an abbreviation of the form (:FOO FOO), useful for binding plist values. If you prefer to keep the stronger connectedness(?) between the sentences, and/or avoid introducing a metaname with no inherent meaning: Specifically when SYMBOL is a keyword :KEY, it is an abbreviation of the form (:KEY KEY), which can be useful for binding plist values. > +See `map-elt' for an explanation of the used equality tests. s/used/relevant/ would avoid the passive voice, if you prefer. Or 'for details on key lookup', or ... [ Trying to get on Eli's non-naughty list. ] > If it's not clear: I changed :SYMBOL to :FOO because the original text > called SYMBOL a keyword and then used SYMBOL and :SYMBOL (although then > only :SYMBOL would be the keyword) - I found that confusing. :KEYWORD > would also be confusing, so I went with the placeholder "FOO". I'm confused, I thought FOO stood For Obfuscation Only ;). Thanks, -- Basil