From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#64619: [PATCH] Add toggle-window-dedicated command Date: Mon, 21 Aug 2023 11:23:18 +0000 (UTC) Message-ID: <87bkf0prkq.fsf@catern.com> References: <87h6ovgnpn.fsf@catern.com> <387ee04aa9601b936ac5@heytings.org> <87350ere4n.fsf@catern.com> <387ee04aa97c3477c4f3@heytings.org> <87zg2mpuv9.fsf@catern.com> <387ee04aa9572975a3cd@heytings.org> <83edjyxmuz.fsf@gnu.org> <22de08b62bd05dc884c9@heytings.org> <83wmxqw1xf.fsf@gnu.org> <22de08b62bfcc659fbd6@heytings.org> <83ttsuw0tr.fsf@gnu.org> <22de08b62b6d15a880af@heytings.org> <83sf8evx98.fsf@gnu.org> <22de08b62b4b6e98a722@heytings.org> <87fs4dpzz5.fsf@catern.com> <22de08b62b5a6672f446@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4933"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64619@debbugs.gnu.org, philipk@posteo.net, sbaugh@janestreet.com, rudalics@gmx.at, Eli Zaretskii , drew.adams@oracle.com To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 13:24:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qY31A-00010f-RL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 13:24:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY30t-0002wf-Rf; Mon, 21 Aug 2023 07:24:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY30q-0002wO-N4 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 07:24:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY30q-0004WE-C4 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 07:24:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qY30s-0004Vz-2K for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 07:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 11:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64619-submit@debbugs.gnu.org id=B64619.169261700817309 (code B ref 64619); Mon, 21 Aug 2023 11:24:02 +0000 Original-Received: (at 64619) by debbugs.gnu.org; 21 Aug 2023 11:23:28 +0000 Original-Received: from localhost ([127.0.0.1]:55693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY30J-0004V6-QY for submit@debbugs.gnu.org; Mon, 21 Aug 2023 07:23:28 -0400 Original-Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:13186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY30H-0004Uu-Of for 64619@debbugs.gnu.org; Mon, 21 Aug 2023 07:23:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=/wKbmBQaxWTrHMHGzuhrWDPPZ3EJw85vUoERXBurdz0=; b=Pmemfq1mzBarXiDPtjSxMQyUx0RR4RbOs9U4NaZyPPApPUqYIZybBykcm0dqeHyhdFYP Yp74T0PU7zbwZzKo7+clE1qkFMcgpwe5O0joJTuZqcCNxTP8uOzPdDbkj/RazIija2mX9v 1l+Ma+AfMx3pBotR8g8AyIi9Lpvu2PIyGwFa9XyHl58sVfB+PX7mMTNF1zoAqs35V8dI5g 95kNUOzvPkhNgN0aseRKTE/G1ca0g8SQqCOzwN+we9IGYifQ+PvHkS8DmelPn2h/5rMsek WgCCZK1tFyVdV9oRfOKHEos6GZOe5LDKpHAzLFDDcBByjYJNmubu0lfTP5ew4TMg== Original-Received: by filterdrecv-66949dbc98-s5rnx with SMTP id filterdrecv-66949dbc98-s5rnx-1-64E34926-9 2023-08-21 11:23:18.062604894 +0000 UTC m=+2931646.312320751 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-6 (SG) with ESMTP id uzMllQIKSU2trh6IaUGU_g Mon, 21 Aug 2023 11:23:17.948 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=heytings.org Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 8759160059; Mon, 21 Aug 2023 07:23:17 -0400 (EDT) In-Reply-To: <22de08b62b5a6672f446@heytings.org> (Gregory Heytings's message of "Sun, 20 Aug 2023 21:56:45 +0000") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbIUxhLnwYHs7eVUgSkYbOkGOvbuU0wpeUZdYVp/QPMqeYgxjHb5DhZpbXEXjjdZcnREriadBMk8MX2KZq1QcgzBw5mycm+3KdW7XeTPhTUayahj4PmKgZbGCX0rhHwbNDqZZ0RZ4LOvZyL4YBUJ+LRLNMI6q1MmByXXN0tS2umhDw== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268079 Archived-At: Gregory Heytings writes: >> >> I didn't know about switch-to-buffer-in-dedicated-window. It does >> resolve the basic annoyance I described, of C-x b not working. >> > > Great! To be clear, as I said, I still don't think the existence of switch-to-buffer-in-dedicated-window means toggle-window-dedicated should default to weak dedication :) >> But, it affects all windows, not just ones that have been >> interactively dedicated by the user. >> > > Indeed, that option is used for C-x b in all dedicated windows. > >> >> I personally have just set switch-to-buffer-in-dedicated-window to >> `pop', so that C-x b works when I happen to be in a window which was >> made strongly dedicated by a Lisp program. But for windows which I >> interactively choose to dedicate with toggle-window-dedicated, I >> think I'd prefer the `t' behavior. Which is effectively what we >> have now by weakly dedicating the window. >> > > It is wise to go into such refinements for a new command that, as Eli > says, is a bit borderline? Right now window dedication is not even > mentioned in the Emacs manual. Perhaps a new value for > switch-to-buffer-in-dedicated-window, which would prompt the user and > offer them the choice to either display the buffer in the current > window or in another window, would be enough (and more generally > useful)? No "refinments" are necessary, this is exactly the behavior which is achieved by just using weak dedication, like the command in my patch currently does. I'm happy to make it customizable, though. I just believe the default should be weak dedication.