From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil Date: Sun, 03 Sep 2023 10:52:39 -0700 Message-ID: <87bkejnm6i.fsf@breatheoutbreathe.in> References: <871qfxvvw9.fsf@breatheoutbreathe.in> <83lee4vcac.fsf@gnu.org> <87o7ixe1e2.fsf@breatheoutbreathe.in> <83o7ixqatx.fsf@gnu.org> <87fs46cn6u.fsf@breatheoutbreathe.in> <838r9ymfh5.fsf@gnu.org> <874jkmck9j.fsf@breatheoutbreathe.in> <83v8ct9gmg.fsf@gnu.org> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16131"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , jonas@bernoul.li, 65414@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 20:32:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcrtY-0003z3-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 20:32:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcrtF-0002LJ-0w; Sun, 03 Sep 2023 14:32:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcrtD-0002JU-7w for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 14:32:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcrtC-0008St-WC for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 14:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcrtC-0001w4-CJ for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 14:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65414-submit@debbugs.gnu.org id=B65414.16937658877400 (code B ref 65414); Sun, 03 Sep 2023 18:32:02 +0000 Original-Received: (at 65414) by debbugs.gnu.org; 3 Sep 2023 18:31:27 +0000 Original-Received: from localhost ([127.0.0.1]:46899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcrsd-0001vI-Fw for submit@debbugs.gnu.org; Sun, 03 Sep 2023 14:31:27 -0400 Original-Received: from out-226.mta0.migadu.com ([91.218.175.226]:47707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcrsY-0001v6-5J for 65414@debbugs.gnu.org; Sun, 03 Sep 2023 14:31:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693765880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vmXA6EzrTcDLpsVQRNq7GKoPD5gwr2GFs2CXi7CF0Ac=; b=NP/mKpD8jcF9+0deFkjBpgqe0AYnnMtpYnGxrU4NvxnxSLAxBBkdUaWdHqXBNOmAKt0+AT ByKXw4d3cayhVSJJ3RMI5F+cpzATjljUh7+XdO9stP6l/enq/xRJ57nWFXomzb+B+Mbjz2 dzx+7CIzxOzrgPCcx8qWNHvoxFvjD3c= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269189 Archived-At: Stefan Monnier writes: > [ Arguably, it would be even better to arrange for `hyperdrive.el` to > save its buffers "in the usual way", i.e. relying on > `buffer-offer-save`, `save-buffer`, `buffer-save-without-query, ... ] I was not aware of `buffer-offer-save`. Thank you for the suggestion! Since we already rely on `save-buffer`, setting `buffer-offer-save` to t is much simpler than adding to `save-some-buffers-functions`. It also resolves the interference between Magit and hyperdrive.el. However... I wonder what the intended purpose of `save-some-buffers-functions` is if packages like `hyperdrive.el` are intended to use `buffer-offer-save`? Joseph