From: Visuwesh <visuweshm@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 64584@debbugs.gnu.org
Subject: bug#64584: 29.0.91; skeleton: cannot pass `str' as argument to some functions
Date: Tue, 12 Sep 2023 08:06:25 +0530 [thread overview]
Message-ID: <87bke8kthy.fsf@gmail.com> (raw)
In-Reply-To: <jwvpm2omkg1.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 11 Sep 2023 18:12:28 -0400")
[திங்கள் செப்டம்பர் 11, 2023] Stefan Monnier wrote:
>>> It should work if you can change your skeleton to something like:
>>>
>>> (define-skeleton test-skeleton ""
>>> (file-relative-name (read-file-name "P: "))
>>> str
>>> (shell-quote-argument str))
>>>
>>> where that first use of `str` will convert it from something that "read
>>> a string according to INTERACTOR" to the actual string.
>>
>> ... this inserts the directory twice. :-(
>
> Of course, it changes the behavior of your skeleton.
> I assumed that your *real* skeleton does something else anyway, so
> I showed what kind of change might help.
>
> To do what your above skeleton does, you simply can't use `str`.
> You need something like:
>
> (define-skeleton test-skeleton ""
> nil
> (shell-quote-argument (file-relative-name (read-file-name "P: "))))
>
> instead.
Yes, of course. I end up having to do something like the let form below
(defun vz/read-relative-filename (&optional prompt dir)
(let ((file (read-file-name (or prompt "Filname: ") dir "")))
(if (equal file "")
""
(file-relative-name file default-directory))))
(define-skeleton imagemagick-collage-images
"Collage/montage multiple images using imagemagick."
nil
"montage "
((let ((file (vz/read-relative-filename "Image: ")))
(if (equal file "")
""
(shell-quote-argument file)))
str " ")
"-geometry 00 "
"-tile " (skeleton-read "How many columns (horizontal)? ") "x"
(skeleton-read "How many rows (vertical)? ")
(shell-quote-argument (vz/read-relative-filename "Out: ")))
I was hoping I could avoid doing this. I wanted to ask you why the eval
form used by skeleton errors but now I realise that str is a list when
it is eval'ed in the example I gave in the OP; I was thinking of eval as
some kind of macroexpansion instead. I disturbed you all for nothing,
sorry.
I can do
(define-skeleton test
""
(read-file-name "p: ")
(shell-quote-argument (eval str)))
instead and that works without the error. I do wonder if the eval can
be avoided but this bug can be closed regardless.
>> AFAIU, using 'str should prevent the insertion of the value but that
>> signals the same error.
>
> Sorry, I don't know what you mean by that.
I meant this part in skeleton-insert's docstring
Quoted Lisp expressions are evaluated for their side-effects.
>> I tried (progn str (shell-quote-argument str))
>> instead but the same error again.
>
> Of course: any use `str` within an actual expression (as opposed to
> using it as a skeleton element) will work reliably only if that occurs
> after a use of `str` as a skeleton element.
>
>
> Stefan
Thanks for your patience and help.
next prev parent reply other threads:[~2023-09-12 2:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 17:05 bug#64584: 29.0.91; skeleton: cannot pass `str' as argument to some functions Visuwesh
2023-09-11 13:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 15:20 ` Visuwesh
2023-09-11 22:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 2:36 ` Visuwesh [this message]
2023-09-12 3:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 12:24 ` Visuwesh
2023-09-12 13:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 14:50 ` Visuwesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bke8kthy.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=64584@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).