From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Date: Tue, 07 Nov 2023 20:39:07 +0100 Message-ID: <87bkc59wv8.fsf@hyperspace> References: <877cnn4z2v.fsf@hyperspace> <87ttq5u9fj.fsf@posteo.net> <87ttq5bx2y.fsf@hyperspace> <87r0l91vww.fsf@posteo.net> <87r0l9fsl1.fsf@hyperspace> <871qd91l9e.fsf@posteo.net> Reply-To: Tony Zorman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10581"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, 66567@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 07 20:39:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0RvD-0002Zv-Th for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Nov 2023 20:39:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0Rv4-0005ip-4W; Tue, 07 Nov 2023 14:39:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0Rv2-0005i0-CR for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 14:39:24 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0Rv2-0002nJ-4I for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 14:39:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0Rvd-0002rF-TI for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 14:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tony Zorman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2023 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66567-submit@debbugs.gnu.org id=B66567.169938599910972 (code B ref 66567); Tue, 07 Nov 2023 19:40:01 +0000 Original-Received: (at 66567) by debbugs.gnu.org; 7 Nov 2023 19:39:59 +0000 Original-Received: from localhost ([127.0.0.1]:43293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Rvb-0002qt-1B for submit@debbugs.gnu.org; Tue, 07 Nov 2023 14:39:59 -0500 Original-Received: from mout-p-201.mailbox.org ([2001:67c:2050:0:465::201]:59892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0RvZ-0002qe-2I for 66567@debbugs.gnu.org; Tue, 07 Nov 2023 14:39:58 -0500 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SPz711dgnz9sh8; Tue, 7 Nov 2023 20:39:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1699385949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e6AXj6Ad1nMbP+li7cRNLh1dbobpbuEvxDC/NVnBBtM=; b=W0pTSzwT1Dlv9ltKUnjmh7vgYVDcJpw7H/ih8wBttTFCGh8yUP0t7hoER2Uq9YZARH8P2p 199zB3vvQXLwsq/JKPJj4+Hagj5EusY7T4yYADK2CEOfMbdNVHMQIgw1WVfWF95zxyJhSf L2w4u7SxuJvdfdXOQpd+3nsbRhl0PDecyaNeri7uBm9T53Xq4oe3Ofup7KvEMf+ZCipBNh hvKHs4AAnhGxj7VRSpmyTNU2HAzAnuG1q6t41mht7QQhXDJ7sa7C8g9GU3Saz9i04jz7Ys MjgbNowPi4ST/m5vBXqDQzOLgXEIyKp20XOANP7aOAZuF/+rvmsKx64EyGROBw== In-Reply-To: <871qd91l9e.fsf@posteo.net> X-MBO-RS-META: qh8s7rzs4ew18ma47hm3r6iahtmpwbt1 X-MBO-RS-ID: 48a1b7e52a5cc55c1b2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273945 Archived-At: On Wed, Nov 01 2023 16:38, Philip Kaludercic wrote: > Tony Zorman writes: >> On Wed, Nov 01 2023 12:48, Philip Kaludercic wrote: >>> Tony Zorman writes: >>>> On Wed, Nov 01 2023 09:09, Philip Kaludercic wrote: >>>> >>>>> Why is use-package checking for valid keywords in the first place? >>>> >>>> Better error messages, mostly. Especially people switching from >>>> quelpa/straight/vc-use-package might be surprised that :vc is not a >>>> drop-in replacement for those packages. I feel like alerting them to >>>> this fact sooner rather than later makes for a better experience. >>> >>> IIUC this would raise an error when an unknown keyword is encountered, >>> right? >> >> Yes, a declaration like >> >> (use-package foo >> :vc (:url "url" :blargh "123")) >> >> would result in the following message >> >> =E2=9B=94 Error (use-package): Failed to parse package foo: use-pack= age: Keyword :vc received unknown argument: :blargh. Supported keywords are= : (:url :branch :lisp-dir :main-file :vc-backend :rev :shell-command :make = :ignored-files) >> >> Things get a bit muddier if ':blargh' would be passed down to >> package-vc-install. > > What I was wondering, was if it would make sense to raise an warning > instead. Now I'm a bit confused: where exactly? Inside of use-package or package-vc? Either way, I think raising an error when the user inputs nonsense is totally justified=E2=80=94I'd just like that error to be understandable as quickly as possible. Tony --=20 Tony Zorman | https://tony-zorman.com/