bug#17948: 24.3; cperl: Needs an equivalent to `c-file-style'

[john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Harald Jörg <haj@posteo.de> writes:

> Eli Zaretskii writes:
>
>>> Cc: Lars Ingebrigtsen <larsi@gnus.org>, Stefan Kangas <stefankangas@gmail.com>
>>> From: Harald Jörg <haj@posteo.de>
>>> Date: Mon, 08 Jan 2024 08:23:35 +0000
>>> [...]
>>> I suggest this patch should go to the emacs-29 branch.
>>
>> Sorry, no new commands/features on the release branch at this time.
>> This should go to master.
>>
>> Thanks.
>
> Thanks for reviewing!
>
> I understand - and have now pushed the patch to master.

This commit causes a couple of cperl-mode indent tests to start
failing. Attached is the log from running:

  make -k -C test check-lisp-progmodes


[-- Attachment #2: cperl-mode-tests.log --]
[-- Type: text/plain, Size: 8160 bytes --]

Running 57 tests (2024-01-09 10:00:55-0600, selector `(not (or (tag :expensive-test) (tag :unstable)))')
   passed   1/57  cperl-test-attribute-list-rx (0.000238 sec)
   passed   2/57  cperl-test-attribute-rx (0.000127 sec)
   passed   3/57  cperl-test-bug-11733 (0.002425 sec)
   passed   4/57  cperl-test-bug-11996 (0.001372 sec)
   passed   5/57  cperl-test-bug-14343 (0.002349 sec)
   passed   6/57  cperl-test-bug-16368 (0.000173 sec)
   passed   7/57  cperl-test-bug-19709 (0.001242 sec)
   passed   8/57  cperl-test-bug-22355 (0.000636 sec)
   passed   9/57  cperl-test-bug-23992 (0.001337 sec)
   passed  10/57  cperl-test-bug-25098 (0.000780 sec)
   passed  11/57  cperl-test-bug-28650 (0.001259 sec)
   passed  12/57  cperl-test-bug-30393 (0.001014 sec)
   passed  13/57  cperl-test-bug-35925 (0.001159 sec)
End of `/ ... /' string/RE not found: (scan-error Unbalanced parentheses 7 13)
   passed  14/57  cperl-test-bug-37127 (0.977492 sec)
   passed  15/57  cperl-test-bug-42168 (0.001213 sec)
   passed  16/57  cperl-test-bug-45255 (0.000506 sec)
   passed  17/57  cperl-test-bug-47112 (0.001242 sec)
   passed  18/57  cperl-test-bug-47598 (0.000947 sec)
   passed  19/57  cperl-test-bug-64190 (0.005074 sec)
   passed  20/57  cperl-test-bug-64364 (0.005063 sec)
   passed  21/57  cperl-test-bug-65834 (0.000903 sec)
   passed  22/57  cperl-test-bug-66145 (0.004820 sec)
   passed  23/57  cperl-test-bug-66161 (0.001057 sec)
   passed  24/57  cperl-test-bug-997 (0.000413 sec)
   passed  25/57  cperl-test-fontify-attrs-and-signatures (0.003491 sec)
   passed  26/57  cperl-test-fontify-class (0.000867 sec)
   passed  27/57  cperl-test-fontify-declarations (0.000347 sec)
   passed  28/57  cperl-test-fontify-punct-vars (0.001012 sec)
   passed  29/57  cperl-test-fontify-special-variables (0.000342 sec)
   passed  30/57  cperl-test-fontify-sub-names (0.002409 sec)
Scanning for "hard" Perl constructions...
End of here-document `HERE' not found.
End of here-document `HERE' not found.
Scanning for "hard" Perl constructions...
End of here-document `THERE' not found.
End of here-document `THERE' not found.
Scanning for "hard" Perl constructions... done
   passed  31/57  cperl-test-here-doc-missing-end (0.001749 sec)
   passed  32/57  cperl-test-heredocs (0.041433 sec)
Precede char by C-q to avoid expansion
   passed  33/57  cperl-test-hyperactive-electric-else (0.002132 sec)
   passed  34/57  cperl-test-identifier-rx (0.000499 sec)
   passed  35/57  cperl-test-identify-heredoc (0.001102 sec)
   passed  36/57  cperl-test-identify-no-heredoc (0.001232 sec)
   passed  37/57  cperl-test-imenu-index (0.003937 sec)
Test cperl-test-indent-exp backtrace:
  signal(ert-test-failed (((should (equal got expected)) :form (equal 
  ert-fail(((should (equal got expected)) :form (equal "test case whil
  (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de
  (let (form-description-9) (if (unwind-protect (setq value-7 (apply f
  (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti
  (let* ((fn-5 #'equal) (args-6 (condition-case err (list got expected
  (progn (insert code) (goto-char (point-min)) (funcall cperl-test-mod
  (unwind-protect (progn (insert code) (goto-char (point-min)) (funcal
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let ((name (match-string 1)) (code (match-string 2)) (expected (mat
  (while (re-search-forward (concat "^# ?-+ \\_<\\(?1:.+?\\)\\_>: inpu
  (progn (insert-file-contents (expand-file-name "cperl-indent-exp.pl"
  (unwind-protect (progn (insert-file-contents (expand-file-name "cper
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (closure (t) nil (let* ((fn-0 #'eq) (args-1 (condition-case err (lis
  #f(compiled-function () #<bytecode 0x1fe51f30ad42b54d>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x1fe51f30ad42b54d
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name cperl-test-indent-exp :documentation 
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/cperl-mode
  command-line()
  normal-top-level()
Test cperl-test-indent-exp condition:
    (ert-test-failed
     ((should (equal got expected)) :form
      (equal
       "test case while loop:\n{\n    while (1) {\n\11say \"boring loop\";\n    }\n    continue {\n\11last;\n    }\n}\n"
       "test case while loop:\n{\n  while (1) {\n    say \"boring loop\";\n  } continue {\n    last;\n  }\n}\n")
      :value nil :explanation
      (arrays-of-different-length 96 92
				  "test case while loop:\n{\n    while (1) {\n\11say \"boring loop\";\n    }\n    continue {\n\11last;\n    }\n}\n"
				  "test case while loop:\n{\n  while (1) {\n    say \"boring loop\";\n  } continue {\n    last;\n  }\n}\n"
				  first-mismatch-at 26)))
   FAILED  38/57  cperl-test-indent-exp (0.002078 sec) at lisp/progmodes/cperl-mode-tests.el:100
   passed  39/57  cperl-test-indent-styles (0.006402 sec)
   passed  40/57  cperl-test-package-regexp (0.000558 sec)
   passed  41/57  cperl-test-prototype-rx (0.000626 sec)
   passed  42/57  cperl-test-signature-rx (0.000521 sec)
   passed  43/57  cperl-test-unicode-arrays (0.003492 sec)
   passed  44/57  cperl-test-unicode-fhs (0.001231 sec)
   passed  45/57  cperl-test-unicode-hashes (0.003823 sec)
   passed  46/57  cperl-test-unicode-hashkeys (0.002064 sec)
   passed  47/57  cperl-test-unicode-hashref (0.000865 sec)
   passed  48/57  cperl-test-unicode-labels (0.000802 sec)
   passed  49/57  cperl-test-unicode-proto (0.000885 sec)
   passed  50/57  cperl-test-unicode-sub (0.000936 sec)
   passed  51/57  cperl-test-unicode-varname (0.000588 sec)
   passed  52/57  cperl-test-unicode-varname-list (0.001282 sec)
   passed  53/57  cperl-test-version-regexp (0.000345 sec)
   passed  54/57  cperl-test-word-at-point (0.000193 sec)
   passed  55/57  cperl-test-ws+-rx (0.000268 sec)
   passed  56/57  cperl-test-ws-rx (0.000167 sec)
Test test-indentation backtrace:
  signal(ert-test-failed (("Mismatch in test \"cperl-indent1\", file /
  ert-fail(("Mismatch in test \"cperl-indent1\", file /home/jm/src/ema
  ert-test--erts-test(((dummy . t) (code)) "/home/jm/src/emacs/test/li
  ert-test-erts-file("/home/jm/src/emacs/test/lisp/progmodes/cperl-mod
  (closure (perl-indent-parens-as-block perl-indent-level perl-continu
  #f(compiled-function () #<bytecode 0x1fe51f30ad42b54d>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x1fe51f30ad42b54d
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-indentation :documentation nil :
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/cperl-mode
  command-line()
  normal-top-level()
Test test-indentation condition:
    (ert-test-failed
     ("Mismatch in test \"cperl-indent1\", file /home/jm/src/emacs/test/lisp/progmodes/cperl-mode-resources/cperl-indents.erts"
      "{\n    print \"\",\n\11\"\",\n\11foo::bar(),\n\11\"\";\n}\n"
      "{\n    print \"\",\n      \"\",\n      foo::bar(),\n      \"\";\n}\n"))
   FAILED  57/57  test-indentation (0.001704 sec) at lisp/progmodes/cperl-mode-tests.el:1436

Ran 57 tests, 55 results as expected, 2 unexpected (2024-01-09 10:00:57-0600, 1.338509 sec)

2 unexpected results:
   FAILED  cperl-test-indent-exp
   FAILED  test-indentation