From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69606: [PATCH] Ensure default-directory exists when generating diff Date: Thu, 07 Mar 2024 11:19:10 +0100 Message-ID: <87bk7q2vkx.fsf@gmx.de> References: <87v85yo0h7.fsf@posteo.net> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24570"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69606@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 07 11:19:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riAqt-0006BV-0S for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Mar 2024 11:19:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1riAqa-00043X-MX; Thu, 07 Mar 2024 05:19:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riAqZ-00043P-4H for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 05:19:31 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1riAqY-0005qo-RZ for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 05:19:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1riAr3-0002xc-Ka for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 05:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Mar 2024 10:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69606-submit@debbugs.gnu.org id=B69606.170980679311362 (code B ref 69606); Thu, 07 Mar 2024 10:20:01 +0000 Original-Received: (at 69606) by debbugs.gnu.org; 7 Mar 2024 10:19:53 +0000 Original-Received: from localhost ([127.0.0.1]:52623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riAqv-0002xC-1d for submit@debbugs.gnu.org; Thu, 07 Mar 2024 05:19:53 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:50021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riAqr-0002wu-Bc for 69606@debbugs.gnu.org; Thu, 07 Mar 2024 05:19:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1709806751; x=1710411551; i=michael.albinus@gmx.de; bh=kggf56Mf3dYjOZv4MaGb/hFkLg7Bi5UBKW3v6hHE684=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=FrQTRwtRsDlIlCax3eQm0xJ7hRo3UBmn9GxFAanWvBnRuE5seNbJOYsxuiADWq/J s7N84BDYrd1kPkPc1SyoPqzV+9SobNNNEcbGdpIAPE2pV/DPgQ6WMMww62epx+s9R HApbXSD4aNWEVFUD+lcIwu4ddEi0/XMQdfxBoMA94ew33fbyAYdCYioMBDfvkeNaG IJmauVwF3/bUn7yfore7k6yWDOUjYyf0Kswvz0j+XBo2uQuN9mTuGLQ/ZwGF7BuAM RcFCM+8loC2D6X+pPOHp5pULj0qXucFii8K+kxexUQkbiyOsKd8+SOjQB8Xb7B3P4 FtzUczCvd+FVLTQ02g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mv2xO-1qrJAl0BdY-00qxi4; Thu, 07 Mar 2024 11:19:11 +0100 In-Reply-To: <87v85yo0h7.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 07 Mar 2024 09:27:48 +0000") X-Provags-ID: V03:K1:CWWIlHDs20E/K51oMmNPlzDf+dzQN+esKlnYU/EpySaWA1IQR/z hPsLKJrWtC4BauNwRyP3MjRw1dH3kOvRWi4gBdvr69s5mG+9yX41L25EhmnKRHT7XHBpIFB jvDUg0ztZcQHE5fPkSG6qyWBEwYP8/lnPv05Pk5/jnw4cR13aSsDg9yt88qu/NX6/Bd3NNR 6I3N8vcUdxrbkmUKzDbcw== UI-OutboundReport: notjunk:1;M01:P0:OE7KZlw7M2I=;jI7TJKSOOzavIo22LjKJQW7KWi/ VTosB2ComUjJI+/Wl0+C3kyXWHZNGX79nSMuxwkjER1zRGGmEUHNiyTPdoQlWznu3HuYj/9Yw 9khrxNNo9D3H8HLjV4WmqtnsSaJcSXlxXPu4NfvJkI6f00VNwcX4+b/CA6ccMBXSxjiiZXoim dXc4NJXvuDfTLOv9eH9o5qQlB2rvKcBhHQPUUuqx0ZeKK2ZkZUepEKSMFQOtUeIfgHO69Ofel WqN3JG5I081A5FV7eH63z1e/cAjtO0ioQvULUXvCeKbZ/k1wTCJMQirQ95fSZbg5VwWSx1uMa jRoYxFf2bLTTvii1AFwZVf6eEIF61AqdTP+WF0Y5jjxgONS/6OAXCW8ZyZ4AkgUnvRHLiL14P JrOyhDCtrA6EpChVNoZErVxnaLzZ7xki2jjLSU2fBe+Nt5LT4/pvKUHp7C7ewBd1sHubOwUcs PZ/vHhKU+6095TYwjnWErVWzwDNzflIRAol79n1UP+EcfB/emqNWOHiZk8sO59DdQK4Nvk9Ms ZwkxknpgiGTQYLLvhhLsdK/IsmyvFN+T2rx1m/GeiWt3p0B93TuOH3KDILcRbZg2TQ0acA6tu 3iQkMHeWUjV8OX7fReJRKnOOO8grY/8QOyOwKGTKr9xpT1gZMCMo4j6+F0ldErRyCiVSoBK9r Zfx4+M2idAfs6GFtcFt6SydYwWrvoLJsJZIx4OdxU61efqRJsBu/FekPrEvZ/3gSPtVBY8Sq7 c2LoDnfQU+UZQL1/EdzC/DYOlsg0IUr7mRbEdssnUXzW47LGATd/TsDdKMbEAHycg89NiQec X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281157 Archived-At: Philip Kaludercic writes: Hi Philip, > diff --git a/lisp/vc/diff.el b/lisp/vc/diff.el > index a64fbc47853..47566dbc40b 100644 > --- a/lisp/vc/diff.el > +++ b/lisp/vc/diff.el > @@ -188,7 +188,9 @@ diff-no-select > (list (or old-alt old) > (or new-alt new))))) > " ")) > - (thisdir default-directory)) > + (thisdir (if (file-exists-p default-directory) > + default-directory > + (expand-file-name "~")))) > (with-current-buffer buf > (setq buffer-read-only t) > (buffer-disable-undo (current-buffer)) I would use temporary-file-directory (or even small-temporary-file-directory). Spamming the home directory with (temporary) diff files doesn't sound like a good idea. > Any other ideas? Perhaps we should always set the default directory to > that Perhaps, but I don't know whether there are undesired side effects, for example when using relative file names. OTOH, if default-directory is remote or unwritable, we might have problems anyway. Best regards, Michael.