From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing Date: Wed, 17 Apr 2024 15:57:56 +0200 Message-ID: <87bk688523.fsf@gmx.net> References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> <865xwgi4a5.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10977"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70413@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 17 15:59:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rx5oY-0002d2-GD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Apr 2024 15:59:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx5oJ-00058E-2x; Wed, 17 Apr 2024 09:58:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx5oH-000583-Tg for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 09:58:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx5oH-0002Ki-Bz for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 09:58:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rx5oT-0008Jt-S3 for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 09:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Apr 2024 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70413 X-GNU-PR-Package: emacs Original-Received: via spool by 70413-submit@debbugs.gnu.org id=B70413.171336230031723 (code B ref 70413); Wed, 17 Apr 2024 13:59:01 +0000 Original-Received: (at 70413) by debbugs.gnu.org; 17 Apr 2024 13:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx5nn-0008Fa-Lr for submit@debbugs.gnu.org; Wed, 17 Apr 2024 09:58:20 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:44231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx5nj-0008ED-Pg for 70413@debbugs.gnu.org; Wed, 17 Apr 2024 09:58:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713362276; x=1713967076; i=stephen.berman@gmx.net; bh=dTXA/6QwoqJlKpcM91iHJ2V8AgdxvgwPYK+LcAnooHM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=JA4vs+T+XpE8jhlmdl9FLHd8I/pKWJH7QHjd5xiJpNyu49Z3pnFHRFiCh64BKZtl GohrbZSwbnReC344zmQSsFVOkSP0tQuTT9CpBOY8E33CTIDVUmWBg/y8JgyN61+o5 eXdvZWJ71u4Yubbo4g615mJTy+AVYtIaFpbbG/JwMagYA3uBzON1U2z3rl+wIAusz 9VbcI5WfkzLkkMRwhZ6NWq4T5mtutqTqyRrlwYF1Fh+eHhEiruox4c8K7DK1uuljK pfYBgRIXjWN1F/GZRZ2kvNzALseubQVwLhk6OX2RCXw9H2gVpSb8iZNIyUexlQHZr G8cLspGSbQStrd+oIw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.94.216]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDQic-1s4H3a2tHy-00ASz2; Wed, 17 Apr 2024 15:57:56 +0200 In-Reply-To: <865xwgi4a5.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Apr 2024 15:04:34 +0300") X-Provags-ID: V03:K1:S8Rsvk40s4bWA2GTA+SAIM5IIHbY5UxELA/OryslfvuFD9K97t5 hYnrZl6hmfzTQuDvPCrlJXIoSoAEkPIBDuZALwieDiUUPfWc0p0Cn0l1RZeuZ+sl+4sg4+E 28esGNxp9SUSV/rJ5+RdD71a3TwyKnuopaSX0A2iRzzYpKKQ/sv3Nw8NQTgyP1cqrqroSNV OfSR6KBy8T0KkH/+7Rvlg== UI-OutboundReport: notjunk:1;M01:P0:yFBqtd++FOU=;insuuNtSFeZAJZzh4FQt0MkIlr+ ZFikFazkXsgrzHJFCI/gIv8ni12KnwkeKMiuiz4tE+eUb1LtyS1vMZXMTItvG1sd1mv3w8rQn IPTlG9NUePwptM+tED3pGNbTG+olpxX9bPE0SwpPXOvVcCBS0EXat7dMapGzoHkc7tAygHsxm bspHBdLbCpReeE7yg3AxA0I9qwR79k0kKv4w9r9RYU3RRMBfeDjYoGzFP51XJJHli2eYoGXqk HpiA9gtjXNp0LqXloXoyPYJXhmYduNbETrCIXjIhz0vjz0A0pDtlJZDKk4cEB6qHZc2j4dnwS 6T9ec+dUO1WqUPIdhxqmOF2EZiTj/ol2AYlr0rifM2ZagYso3kZZh1f99mNjT6Tt/WAwCxuFw 0B+TyctnfWzGAPizqo2Z3cwQ9U0ErNUIHwH89ee41WuY4B8ksUhj539/d0z9vUX2hidxRN2T0 Q1bcH5ohTB76NJC40yj7mPrilsEzzaTOdEyPJjd776PQx6Hf6N7LsDgPcCZhszhSCOgR6XjKG 7sXXregg+WrRaucKdBSS9++rzIgcmv0GDEqKmUQXkeM8rlEuV5af/umzWDEYA+P07MyZtQle+ TJ096BtuwVJVKrvZw4I33TEoF2jGjglEdeM4GgIIum/scGK/yKpyj+p5r7tHXyPrCTJLXleyT mjttSbzHuHbdH+xqQna+Gtv8u3BihvYJAKnsgqotavIjeA1y9o7QwX4sOB7OCWMzoghHwNsTi ZD9/Pknl2JYte7pSb1LAhH5E0VWNdcO/B0D1YnRUldiCquLEV80oV6aYFrNLAC9+0LW4oO5P X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283498 Archived-At: On Wed, 17 Apr 2024 15:04:34 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 70413@debbugs.gnu.org >> Date: Wed, 17 Apr 2024 00:04:33 +0200 >>=20 >> > Thanks; see the attached patch. I think this user option should also = be >> > documented in the Widget manual, so the patch includes that as well. >> > The Widget manual has a node for widget customizations, so I added it >> > there. But I think it is helpful to mention it also in the node >> > "Widgets and the Buffer", where the tabbing commands `widget-forward' >> > and `widget-backward' are documented, so that patch does that too. If >> > you confirm this is ok, I'll push the code and doc changes to master. >> > >> > Steve Berman >>=20 >> ... and here's the patch: > > LGTM, with 2 minor comments: > >> +@defopt widget-skip-inactive >> +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} > ^^^^^^^^^^^^^^^^^ Oops, that was copy-pasta; thanks for catching it. > This should probably be @kbd{key{TAB}}. Or rather @key{TAB}, right? That's what's used earlier in the Widget manual and IIUC is what (info "(texinfo) @key") recommends. >> +(@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, >> +also bound to @kbd{M-@key{TAB}}) skips over inactive widgets. > ^ > I'd add a comma there. AFAIK, according to the usual rules of comma usage in English, a comma should not be used there, since the entire phrase "navigating between widgets by =E2=80=98=E2=80=99 (=E2=80=98widget-forward=E2=80=99) or = =E2=80=98S-=E2=80=99 (=E2=80=98widget-backward=E2=80=99, also bound to =E2=80=98M-=E2=80=99)" is the subject of "skips". But I= grant that, due to the length of this phrase and the parenthetical phrases it includes, it does prosodically "feel" like there should be a comma. The following reformulation avoids this, and moreover conforms better to the style of the Widget manual by using the imperative form "skip": If non-@code{nil}, skip over inactive widgets when using @key{TAB} (@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, also bound to @kbd{M-@key{TAB}}) to navigate between widgets. Is this formulation acceptable? Steve Berman