From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72404: 30.0.60; Customization of options is broken Date: Sun, 04 Aug 2024 12:00:23 +0200 Message-ID: <87bk28vc94.fsf@gmx.net> References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> <878qxga6vv.fsf@gmx.net> <87ttg48863.fsf@gmx.net> <86a5hsu3q7.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36728"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72404@debbugs.gnu.org, jm@pub.pink, maurooaranda@gmail.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 12:02:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saY49-0009Nj-RP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 12:02:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saY3q-0007zR-87; Sun, 04 Aug 2024 06:01:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saY3a-0007yc-Vk for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 06:01:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saY3Z-0007BL-0F for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 06:01:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=hqmsjLKy04wCBk/tzWIYtjn2H5fTjX9/71DYm3XZOKk=; b=Ff/xLX94y+clT5QEqg6Zfn6WK39pyJdZHpRqH7E4eOglu3kgER9npdu7aN9VC4X7albX9S4kNFauKu1VdzQMlkPWW7itfg7rlqdhiFVfon2vdvsrEWxeLl471iWvhMofgh+5I0bX5/LQWbmChXzliOPSdGlDiCoggTxdK5sMQNrC6GzG8DY0EHVUP9BoeMiL8sxeVIoM2yyraxCHGM4uTjDAguQXg5PI0D0EEUEZggsSzTd3zo9ZbPrZylCUUR37s3lNPro37Gc0VNG2ZjrkMuWUq6dXFSd84/RsN44nzTKa0Jqrf+ayletXJ676QGMaGBbhlOT3FmUaGRKe314z6w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saY3t-0002pO-S3 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 06:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72404 X-GNU-PR-Package: emacs Original-Received: via spool by 72404-submit@debbugs.gnu.org id=B72404.172276566510714 (code B ref 72404); Sun, 04 Aug 2024 10:02:01 +0000 Original-Received: (at 72404) by debbugs.gnu.org; 4 Aug 2024 10:01:05 +0000 Original-Received: from localhost ([127.0.0.1]:55546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saY2z-0002mj-2l for submit@debbugs.gnu.org; Sun, 04 Aug 2024 06:01:05 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:45767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saY2v-0002lw-Mx for 72404@debbugs.gnu.org; Sun, 04 Aug 2024 06:01:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1722765630; x=1723370430; i=stephen.berman@gmx.net; bh=hqmsjLKy04wCBk/tzWIYtjn2H5fTjX9/71DYm3XZOKk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PU6K+8c8awGNBti4yG3zU5/qH5OVTUFCwZHZiEZJQKfrjZ1nKac7foxeF2yAfBgI Kx/obgzyh/ykg24erSilckhEQuHqpbiw67inZWlkzoqNHVnvXnBOdEEIL0zbMiZRs W+Y41v4u+IgUaaw52yTe4GY026A2UYhJ0pNyI044OF+4JfLz3819gAvSuwnDAcDeZ yqeV5pGH65eG+NZENt+dVOXVgjo4MQoU12fww3W1hDhBpLBZ4NwJ0tUHedfSdkWEu r1fd6yl/U6ej3oL4DECK7fVZ41VU9R4edUZdOzOObXL5w+zx3/3C0MeNdqvhmYj3Q lQ6dJyqeuOhUOLrx5A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.95.222]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEFzx-1sQPYB2VmP-004jbO; Sun, 04 Aug 2024 12:00:30 +0200 In-Reply-To: <86a5hsu3q7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Aug 2024 10:49:52 +0300") X-Provags-ID: V03:K1:KvceWuiB4VcK7yZyrID+ShmUEI/vO8SjAPBdR+azqiDWizVnAFx jJvHbEXPnzykjEYAKd1AvCLcLveLO7QlpgI3QGHQx/ORQAY8F4/zjm2ANQpXVt28Rrz9qpd grig7f4xflMOJ5+w5Y4iuyRiU9Jf1hALJOMM7WvLjZia6ZuVJbtEkS4SXOlgMa6dHYG3dxD i8UT+fyEhPKtCORSqJJeQ== UI-OutboundReport: notjunk:1;M01:P0:/ZCErUCgXjA=;0hx7cnMPk1C1fqXoiXcZ2e9DQXw edenau8mJBsTDvN7Pq/kbzvBbtZ2N4/tF8HhNyS17m3kWTJ/9puGPnIk/PCfCrQP31XCL22ss GF9fXIjwiplEJgfaJi0xRT1atHI+y4oEnD9AvIIylhm1D4BtQdldaRRPhNhJwfeCFXHgLF9bU 5+7JA7sMx4r/LbzIRgUbMZqe5T4/ptGXbhahZPI0gOLL31ARe5m0aUXebbYdeFSqFvvNEg/Wo r6shf0ZHaWlCOwvdSPnt73JwSQqDGy4dtu4Z0crV7H5aNx2Y7ViWN43THdGS0navs/XFEA4Ah YQ047UgVyxdIh9RrHbeLdpTN7U5mntkv5cbf1h567HwJEx3HDtaB11RHdGkJnXjBV6FYvJNyu zHuxncaw6878KHSpdo5MmhFRKg13DpA4aOSr5YqWn61ocgXqI+HrxEv42w3LrPpv6/AQ12y13 rUqZi95AOqLL10cK1SS09iraaEgBSg314waoD3Ix1b1vM/CqbWX4STdWGpeOPrSI1ptqcl5FR UulD8oj55w/dg1oc/KFkrZPf4O+VxuZjgsJi59LtX886g28oH41ABhngHcP6AX/i5MJgGw2yh ywVxduadXTFLMjhHVBRQo2LekdlkAuP5shTz+KWXTXvmeXwlQfCA0nrUT86Itpslc/8LEU3kr qiM8SUvttfC/a+otF658EaG2DF/Sx08F9MkZwKW9ZW161rl4V9pmZPIwFAS4Q++B6i37iRSP+ m4rd84tbvQfX8BAUDWH9PTwkUnd0pClH4K9GnHotOIKFm1ZZfV9INa9GL238Hn8MVIy3cnYZ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289738 Archived-At: On Sun, 04 Aug 2024 10:49:52 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: john muhl , juri@linkov.net, maurooaranda@gmail.com, >> 72404@debbugs.gnu.org >> Date: Thu, 01 Aug 2024 19:28:04 +0200 >> >> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman wrote: >> >> I did happen to have a bit more time for this problem, and I think I've >> found the cause, a single line in commit 8d354925ddb: >> >> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >> index 693991a6f3e..aa653549dad 100644 >> --- a/lisp/wid-edit.el >> +++ b/lisp/wid-edit.el >> @@ -2549,7 +2549,8 @@ widget-checklist-add-item >> (t >> (widget-create-child-value >> widget type (car (cdr chosen))) >> - (widget-specify-selected child))))) >> + ;; (widget-specify-selected child) >> + )))) >> (t >> (error "Unknown escape `%c'" escape))))) >> ;; Update properties. >> >> With this line commented out as in the above patch, I get the expected >> value when carrying out Juri's recipe. Moreover, after making that >> change, I then briefly tested customizing the face widget-unselected >> (which the problematic commit added) to inherit from the default face >> and it shows the labels of unselected check boxes in the default face, >> as it should. So maybe deleting the commented out line above and >> leaving the rest of the change is a sufficient fix. But I have to admi= t >> I don't know why that line causes the problem, and I haven't done enoug= h >> testing of this change to the widget-unselected face feature, so this i= s >> just a status report. > > Thanks, I installed the above fix. Thanks, this seems at least a plausible stopgap. > It turns out the same problem also caused bug#72156, so I've now > merged them. > > I'm leaving this bug open, in the hope that you or someone else will > find the root cause for the regression and fix it. I will try to debug it further, but I do hope Mauro or someone else more familiar with the widget and custom code than I am will look into it. Steve Berman