unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73487@debbugs.gnu.org
Subject: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation
Date: Thu, 26 Sep 2024 22:54:36 +0100	[thread overview]
Message-ID: <87bk0ankrn.fsf@jeremybryant.net> (raw)
In-Reply-To: <868qvec20t.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Sep 2024 10:22:42 +0300")

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Wed, 25 Sep 2024 22:32:56 +0100
>> From:  Jeremy Bryant via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> This proposed patch adds a function documentation where there was none.
>> 
>> Please install on master or provide feedback for further work.
>
> We usually prefer non-block comments, certainly when the comment is
> short.  Can you use that in this case?
>
> Thanks.

Yes, sure.  Revised patch attached with the comment in a single line,
rather than a block.

(I tried to match the style of the surrounding areas of the file but now
realise this was from 1992)

Please install on master or provide feedback for further work.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-cm.c-cmgoto-Add-function-documentation.patch --]
[-- Type: text/x-diff, Size: 597 bytes --]

From afc9916447528682d72a6bd9429b2a6e91d4d28a Mon Sep 17 00:00:00 2001
From: Jeremy Bryant <jb@jeremybryant.net>
Date: Wed, 25 Sep 2024 22:28:04 +0100
Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation

---
 src/cm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/cm.c b/src/cm.c
index ad419ce0af1..e1014af5298 100644
--- a/src/cm.c
+++ b/src/cm.c
@@ -317,6 +317,8 @@ #define	USEHOME	1
 #define	USELL	2
 #define	USECR	3
 
+/* Move the cursor to (row, col), by computing the optimal way. */
+
 void
 cmgoto (struct tty_display_info *tty, int row, int col)
 {
-- 
2.45.2


  reply	other threads:[~2024-09-26 21:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 21:32 bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-26  7:22 ` Eli Zaretskii
2024-09-26 21:54   ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-27  6:20     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk0ankrn.fsf@jeremybryant.net \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73487@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jb@jeremybryant.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).