From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tsdh@gnu.org, 73846@debbugs.gnu.org
Subject: bug#73846: [PATCH] Make djvused emit UTF-8 encoded text
Date: Thu, 17 Oct 2024 14:01:56 +0530 [thread overview]
Message-ID: <87bjzjxh8j.fsf@gmail.com> (raw)
In-Reply-To: <86frovpaf0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Oct 2024 08:26:27 +0300")
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
[வியாழன் அக்டோபர் 17, 2024] Eli Zaretskii wrote:
>> Cc: "Tassilo Horn" <tsdh@gnu.org>
>> From: Visuwesh <visuweshm@gmail.com>
>> Date: Thu, 17 Oct 2024 09:42:30 +0530
>>
>> This is a small patch to make djvused emit UTF-8 encoded text. In the
>> djvu test file that I sent you, outline in the appendix have non-ASCII
>> characters which are written as octal escapes. Rather than unescaping
>> them on Emacs side, we can request djvused to use UTF-8 directly which
>> this patch does. The attached patch does just that.
>
> If you force djvused to emit UTF-8 encoded text, you need to bind
> coding-system-for-read to 'utf-8, to make sure Emacs decodes that
> correctly. I'm guessing your locale uses UTF-8 by default, which is
> why it worked for you.
My locale is a UTF-8 one indeed. I've now let bound
coding-system-for-read around everything inside with-temp-buffer.
> Please also add a comment there explaining what the -u switch does and
> why we use it there.
Done in attached patch, I hope it is clear.
> Thanks.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-djvused-emit-UTF-8-encoded-text.patch --]
[-- Type: text/x-diff, Size: 1830 bytes --]
From a39e50a504c9c24f51c7c646f3cfffcec2f34b85 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Thu, 17 Oct 2024 09:40:34 +0530
Subject: [PATCH] Make djvused emit UTF-8 encoded text
* lisp/doc-view.el (doc-view--djvu-outline): Pass -u to djvused
to make it emit UTF-8 encoded text rather than using octal
escapes for non-ASCII string. (bug#73846)
---
lisp/doc-view.el | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index bbfbbdec925..4d7d36c8a16 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -2026,13 +2026,16 @@ doc-view--djvu-outline
For the format, see `doc-view--pdf-outline'."
(unless file-name (setq file-name (buffer-file-name)))
(with-temp-buffer
- (call-process doc-view-djvused-program nil (current-buffer) nil
- "-e" "print-outline" file-name)
- (goto-char (point-min))
- (when (eobp)
- (setq doc-view--outline 'unavailable)
- (imenu-unavailable-error "Unable to create imenu index using `djvused'"))
- (nreverse (doc-view--parse-djvu-outline (read (current-buffer))))))
+ (let ((coding-system-for-read 'utf-8))
+ ;; Pass "-u" to make `djvused' emit UTF-8 encoded text to avoid
+ ;; unescaping octal escapes for non-ASCII text.
+ (call-process doc-view-djvused-program nil (current-buffer) nil
+ "-u" "-e" "print-outline" file-name)
+ (goto-char (point-min))
+ (when (eobp)
+ (setq doc-view--outline 'unavailable)
+ (imenu-unavailable-error "Unable to create imenu index using `djvused'"))
+ (nreverse (doc-view--parse-djvu-outline (read (current-buffer)))))))
(defun doc-view--parse-djvu-outline (bookmark &optional level)
"Return a list describing the djvu outline from BOOKMARK.
--
2.45.2
next prev parent reply other threads:[~2024-10-17 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 4:12 bug#73846: [PATCH] Make djvused emit UTF-8 encoded text Visuwesh
2024-10-17 5:26 ` Eli Zaretskii
2024-10-17 8:31 ` Visuwesh [this message]
2024-10-18 6:07 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjzjxh8j.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=73846@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).