From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73768: 'read-passwd-mode' can clobber user defined mode lines Date: Sat, 19 Oct 2024 12:44:13 +0200 Message-ID: <87bjzgnzia.fsf@gmx.de> References: <1d3172d5-3704-40c6-92af-8888b0657871@gmx.at> <87v7xxsj4l.fsf@gmx.de> <87wmicqe5a.fsf@gmx.de> <877cacvv0r.fsf@gmx.de> <49fca25a-d5aa-4f14-ae09-52923eb5ce85@gmx.at> <87zfn3w48f.fsf@gmx.de> <298302a6-c037-4297-9a70-5b48a6fbb649@gmx.at> <87iktpvk5z.fsf@gmx.de> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15232"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73768@debbugs.gnu.org, 73768-done@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 19 12:45:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t26xC-0003ig-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Oct 2024 12:45:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t26wp-0000nA-Ld; Sat, 19 Oct 2024 06:44:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t26wo-0000mn-JA for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:44:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t26wo-0004HW-Ag for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:44:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=kTyDRBimT0uA912GZZYXa19VfzcBgIR8cYGiMy9na7E=; b=BHG9mRPm2+rMA9JrxcyDceFCcGyg4qusFfRr2uJMINpYOUzQ2+Flp9Xb0EQiXRtD07aRmnLakiFI2xyMowbeGybFX9OUULJuaf0cqlATyXtezVOR4ua+xw+yMrzSVw3Mh4xKMm2GXkK5l+HP7SJZoT8LyihQnT+8i1vrHZYVeGaqevHfzSqrVnacLhfSHrUtJKJY6Fw46c0K48vX/4qNaxyWy/rRdyycMPUjaENUvCVFtHzt82fEFi91UJ2Ioh2SuS9simg2I+a2SvRcmAYjFWOKLmoNGEPHMWSkdyCcT3e/iqdEko7KW37GwwbYcD8q21tlX65LfcJRpDGH8q1A5w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t26xB-0000ZH-Rx for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2024 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73768 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 73768-done@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17293346962157 (code B ref -1); Sat, 19 Oct 2024 10:45:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Oct 2024 10:44:56 +0000 Original-Received: from localhost ([127.0.0.1]:41606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t26x5-0000Yi-RH for submit@debbugs.gnu.org; Sat, 19 Oct 2024 06:44:56 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t26x3-0000YY-RK for submit@debbugs.gnu.org; Sat, 19 Oct 2024 06:44:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t26wf-0000mD-VS for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:44:29 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t26we-0004HD-6t for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:44:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1729334658; x=1729939458; i=michael.albinus@gmx.de; bh=kTyDRBimT0uA912GZZYXa19VfzcBgIR8cYGiMy9na7E=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=L/1DEmiQMwNL9X4se8TWzw7ZiFFAertw2jdCfGKHIyuB+oPA4JJbNrcVTTjEjuwr Gj8AidHLdoe/1Ln3uH0urTzE9DWzV7RdoUrXhgsLY4KpgimY2vxV1kS6SMPkQ8BKU xXgXsH7rC0dTfULfzPewNzhgmNDqu7jPm6HxFFRPH2IjbOkyw9ZFifCAsme5DZYjK 552WDHlki7cPoI7hvo+UKdEh1pbXVvdmU6Nrdca6boMk1xPq8T5l8qFK6tKXJ/iSY 7Je9XQKEofuGrPX+FyA2EaYVIKJHvIFeKhLSzE/a8OrbHss16jYM5CYbTnSyJ8Rwo mPim79nZmEulmT9K7g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6DWs-1szv5d3mIK-00EmVk; Sat, 19 Oct 2024 12:44:18 +0200 In-Reply-To: <87iktpvk5z.fsf@gmx.de> (Michael Albinus's message of "Fri, 18 Oct 2024 11:23:52 +0200") X-Provags-ID: V03:K1:pUWLaqFSdkLp576G54ME0sEEIdKJSaKCvLqdSS3fCt2zf9WizIb uSaqNbhF26NwszWlQ2m33REWxBoDsxzGhQvczax/NFcKYNweInijIa3p5F5H9qMwLe4Yd3H sXwlLtqwC3FtDPwCdm9dxf8xVBJc+ycVEEn/+JaO1J2CLV+hPn0bPYCd70lmTc88oa1CksN 9rn0r+tZaiAxx9XwuFWlw== UI-OutboundReport: notjunk:1;M01:P0:ZHXUsY6te58=;ovix5/FRMh//GpsHQKoJDAorhYt LD9Mie99alHo6Uobi3EozOCcpGltiQMHMXXgJpSPTK0AHlQQ/k7fC2cWRkWJoCGUYs7oHBLNW SRfHvtmRfjtUk8k4Rz+VmrtTQ7fPDcIaCmy+4I+SDOj1kigsAJWbTWLos5GlMQ9uvledj6uhp +eMAe+4WnUvccGsO023/7B33gPVvbZA6FpkabWDU6Dk/QlkPMbktpQAc0V46qAfB2UFXbsyGp h1cEg9uec7TTEsOP0yrC1BxlLl8nQ3IT28aYhO8QURY5Ahdz7VVAtNj0Oex5kPPbvkUxMTGNb vyXuC37ti5OKRDsOkBVXAPQ+4Ws7Ph1DrtNYw+r4HomkdDyWEdpyn/H2rSD8Ex+O35mYEaf8c 56nQONXdkhkljCzJnAOCcGutgi73Lft6546FdGbYD6/pfyU/T8wZjDO5WNk1GgP5kgP7OTkwY NTYMbiEjVgLxR8PVAbARY+lYplr0fyJqgtj/cUi+AhalmLoYoSjGOLaUYFR7npndOi7Zpe1zH R6oGqgWE/Sy95rzFQLJsefbrWZjijiWE0PwQcKVjekfAUX/nzXqxmT0Hz9SeI3vEWGZn1AplH jzkMOOOSNdwphYppF/fTFvntDKZ91dLXY0ph4j1M7Ltv+cdOISaE1xXPCjOgDPvtf1xad6ULc Q9cbkNcc2DiBM8qnNmzyxj+8EKWQuSbPyxb6z7Jz5C2+LLEk4zDDol2RR4w+OMvV2vdbVUqx5 EX3eEesqSqvMBUjA8fxewjwSESehW/Nc2+msVEllSUVAyHlHHEPQmdrdRK+qJD2WPxviB8cJ Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293869 Archived-At: Version: 30.1 Michael Albinus writes: Hi Martin, >> entering 'read-passwd' does >> >> (add-hook 'post-command-hook #'read-passwd--hide-password nil t)) >> >> while exiting still does >> >> ;; Not sure why but it seems that there might be cases where the >> ;; minibuffer is not always properly reset later on, so undo >> ;; whatever we've done here (bug#11392). >> (remove-hook 'after-change-functions >> #'read-passwd--hide-password 'local) >> >> If that fix of Bug#11392 (or Bug#11397) were really needed, then we >> should remove read-password--hide-password from 'post-command-hook' now. >> But there were no bug reports in the last four years so probably that >> bug was fixed by other means. In either case the current 'remove-hook' >> is a noop now. > > Hmm, yes. While adding read-passwd-mode, I didn't check all settings in > read-passwd. Likely these settings are superfluous now. I will check in > master once the other patch has arrived it. Finally, I've done as you proposed: Remove `read-password--hide-password' from `post-command-hook'. While playing with the recipe of bug#11397, sometimes (not always) the minibuffer was corrupted as hiding the text. So I believe this is the safest change. Pushed to emacs-30. And closing this bug, now. Thanks again for your patient discussion the issue! >> martin Best regards, Michael.