From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 73768@debbugs.gnu.org, 73768-done@debbugs.gnu.org
Subject: bug#73768: 'read-passwd-mode' can clobber user defined mode lines
Date: Sat, 19 Oct 2024 12:44:13 +0200 [thread overview]
Message-ID: <87bjzgnzia.fsf@gmx.de> (raw)
In-Reply-To: <87iktpvk5z.fsf@gmx.de> (Michael Albinus's message of "Fri, 18 Oct 2024 11:23:52 +0200")
Version: 30.1
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Martin,
>> entering 'read-passwd' does
>>
>> (add-hook 'post-command-hook #'read-passwd--hide-password nil t))
>>
>> while exiting still does
>>
>> ;; Not sure why but it seems that there might be cases where the
>> ;; minibuffer is not always properly reset later on, so undo
>> ;; whatever we've done here (bug#11392).
>> (remove-hook 'after-change-functions
>> #'read-passwd--hide-password 'local)
>>
>> If that fix of Bug#11392 (or Bug#11397) were really needed, then we
>> should remove read-password--hide-password from 'post-command-hook' now.
>> But there were no bug reports in the last four years so probably that
>> bug was fixed by other means. In either case the current 'remove-hook'
>> is a noop now.
>
> Hmm, yes. While adding read-passwd-mode, I didn't check all settings in
> read-passwd. Likely these settings are superfluous now. I will check in
> master once the other patch has arrived it.
Finally, I've done as you proposed: Remove `read-password--hide-password'
from `post-command-hook'. While playing with the recipe of bug#11397,
sometimes (not always) the minibuffer was corrupted as hiding the
text. So I believe this is the safest change.
Pushed to emacs-30. And closing this bug, now. Thanks again for your
patient discussion the issue!
>> martin
Best regards, Michael.
next prev parent reply other threads:[~2024-10-19 10:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 9:26 bug#73768: 'read-passwd-mode' can clobber user defined mode lines martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 10:36 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 13:56 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 13:49 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 9:58 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 14:19 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 15:09 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 16:15 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-14 14:56 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-17 7:58 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-17 11:40 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-17 18:10 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 8:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 9:13 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 9:45 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 16:11 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 9:18 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 10:17 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 10:40 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 11:02 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 14:14 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 16:04 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 17:48 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-19 8:29 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-19 8:37 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-19 8:42 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-17 18:09 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 9:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-19 10:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-10-13 15:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjzgnzia.fsf@gmx.de \
--to=bug-gnu-emacs@gnu.org \
--cc=73768-done@debbugs.gnu.org \
--cc=73768@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).