Hello, On Sat 19 Oct 2024 at 01:28pm +03, Eli Zaretskii wrote: >> From: Sean Whitton >> Cc: Dmitry Gutov , Morgan Smith >> Date: Fri, 18 Oct 2024 17:26:28 +0800 >> >> This patch is the rest of this feature. Eli, would you kindly test on >> MS-Windows, please? Just try to edit the message for an unpushed git >> commit and add some Unicode, and see if it works correctly. > > I'm supposed to type 'e' in the log buffer, edit the comment, then > type "C-c C-c"? Yeah, that's right. > When I do the above, I get an error message: > > vc-do-command: Failed (status 128): git --no-pager commit --only > --allow-empty -F c:/Users/EliZ/AppData/Local/Temp/git-msgWaNflu > > and the *vc* buffer says: > > fatal: No paths with --include/--only does not make sense. > > It's possible my Git is very old, but shouldn't this command work with > old versions as well? I've looked into it and what's required is Git 2.11.1 from early 2017. I think we can support older by stashing and unstashing. So please try the attached patch, which does that. -- Sean Whitton