bug#74193: 30.0.92; noquery argument ignored when creating a TLS connection

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Mon, 04 Nov 2024 19:05:17 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Augusto Stoffel <arstoffel@gmail.com>,  74193@debbugs.gnu.org
    >> Date: Mon, 04 Nov 2024 17:38:47 +0100
    >> 
    Eli> Robert, do you know if GnuTLS, as we use it in Emacs, supports this on
    Eli> all platforms?  With both :nowait and non-:nowait?  More generally, I
    Eli> wonder why we don't pass all the parameters to open-network-stream?
    >> 
    >> I donʼt know if itʼs supported everywhere, I suspect the interactions
    >> with :nowait could get interesting. As far as I remember,
    >> `open-gnutls-stream' is supposed to be a 'simple' wrapper, which is
    >> why it doesnʼt support all the keywords.

    Eli> Yes.  But we are going to allow more keywords, it would be good to
    Eli> test them in at least the more popular configurations.

Iʼve re-read the many-headed hydra that is `open-network-stream', and
':noquery' is the only keyword that appears to be missing for
`open-gnutls-stream'. The others are only used when opening plain
connections or when upgrading plain connections to TLS (which should
be avoided if at all possible).

Iʼll see if I can find time to test. I have GNU/Linux, macOS, and if
really needed, MSWindows (I need to test the ALPN changes in any case).

    Eli> In any case, the doc string should be fixed to mention :noquery.
    >> 
    >> Which doc string? `open-gnutls-stream', after this patch?

    Eli> Yes.

OK

Robert
--