From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Trevor Arjeski Newsgroups: gmane.emacs.bugs Subject: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls Date: Sun, 24 Nov 2024 10:17:40 +0300 Message-ID: <87bjy5yuaz.fsf@gmail.com> References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27842"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Randy Taylor , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 24 08:19:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tF6tj-00077K-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Nov 2024 08:19:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tF6tc-0000dS-Om; Sun, 24 Nov 2024 02:19:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tF6ta-0000cf-Tg for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 02:19:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tF6ta-00058v-BU for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 02:19:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=fUB1Oc7/LrxiDAsjw14WNyZ2CPssmg1NsRuS3ikIkSU=; b=iPm5PACSBcCqEKy+Wn6vq7/qj2EXXSNQ7xpWm+IE4ZU8CtFlas3KBmpkPO3rw04AWkHFDyXXJ3f05f6+vHroaNi42itj8beagdYprWlQXd5WqjBz3rTWJ+S51jBOI1FRrySylSQj1DGL005AKSe3uJrKYwvGG3xEZRFbvaQjFibConAPAzvtWbRcSW9iUNSxz2Eqc6CM2Z1LmRmVNJqNLsF/MVZZyKCaSpckDHA/tu1xY/D9sSuV9/1B/ZOkoGLbYZf1T8jOnlwACcnUATloWy0KNlzEikqc3IckHk/VCksQi41XyzOwXLLpP0onJa4/JWrZm3hdpBOJZ72+moLNxA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tF6ta-0002eR-76 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 02:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Trevor Arjeski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Nov 2024 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74277 X-GNU-PR-Package: emacs Original-Received: via spool by 74277-submit@debbugs.gnu.org id=B74277.173243272610165 (code B ref 74277); Sun, 24 Nov 2024 07:19:02 +0000 Original-Received: (at 74277) by debbugs.gnu.org; 24 Nov 2024 07:18:46 +0000 Original-Received: from localhost ([127.0.0.1]:60520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF6tK-0002ds-Hx for submit@debbugs.gnu.org; Sun, 24 Nov 2024 02:18:46 -0500 Original-Received: from mail-lf1-f53.google.com ([209.85.167.53]:50641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF6tJ-0002dk-By for 74277@debbugs.gnu.org; Sun, 24 Nov 2024 02:18:45 -0500 Original-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-53dd9e853ccso1471214e87.1 for <74277@debbugs.gnu.org>; Sat, 23 Nov 2024 23:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732432664; x=1733037464; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fUB1Oc7/LrxiDAsjw14WNyZ2CPssmg1NsRuS3ikIkSU=; b=LWO/yuV17JWrcVDv2xrPeHBEUchO2QxKaf1OHFCCu02PWdhyy7xrHU7SF9IRPPEX7E wF0oTtB8vb0OycE5k07/AFy8hk1BfBcYPAQYJH2QgyYqS3cKOck8ObzzGq9HY533rJcC 3yu71sL1187axN6IuG2WTHjstwEHfp4dunkjTyHHG27e6bqPGw0k9M666OtDs8u/IpOC SJrk7DTcW9FaEM0Kb943mfd78AMKEM+uTfLfyBUV1NaWhJcaylO9ks3/TaQOP16HgStG /bfNdu6U2CGAmejQUerLSQRA1gXo3Dhp3j9y+el3zLKPC3ufcxHenywUVtyIH6CXoAgU psRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732432664; x=1733037464; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fUB1Oc7/LrxiDAsjw14WNyZ2CPssmg1NsRuS3ikIkSU=; b=xJmw3SEWs43+KWa3Pj+BGmUy9TLegp6Da1xEmHL8KRVZKeQ5L9fJt2NcV0D67dY8Ia edClnDUAtky69HWVH3syuujNLvJGSnPGwYcckkHxD8YEm6jBIvyNUSQiSup04nJ+StgI S3NCy047Res8I9gKBrqJepY9ZrV+oYG+Z/4SM7dMH8Lj/fwdQxIUs1Id5NQN9rf2NVFA nKnfiHJ/+VoOolxzLqLRNp6udQ4iGlT/W1yDkRGfTbOurCPnSxun2dfScDHlLNqCflbI Y+X9iXbo79m4BqCCubTqj/kC/Rg6M4O0p1BGoYOPXr1blzXF3v3BY68C5mUVET8s0u1f JmXQ== X-Forwarded-Encrypted: i=1; AJvYcCUGTWeJ4FMnKLWchK3bJTumwFXoPRBghugXr76b4464nFaGHYZD7AjnPpOJaRSLZYuOwljAzA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwHdAhJlliaZKP9L5s6A2RXHUhrPPxF6UvEjKN6g6+bKpQmFf3c 4cMUlSOLJ6ecCTx56bI0r5aPOwcgCCffUeAvOTF+zm/aUEWqIRUK7EGPBTKH X-Gm-Gg: ASbGncvwh6NAaPWXNy2EkSyV3GILn0l79jUT9fqRNNiA7GXhFXywU3pXXu3qoal037a JI8RTHuUCsmF3xbG/VnUz1YhpizNZ0cXC5zhxzKAnpnTwrKC9L2ZgAaA34QZPP25DXuBW93U+J4 EEbgqb0Qqm/3b2PQPkv7NZFnogUPQ2T96UAT/1099hMTq0bs2/pkkvttwccRQebmRIQZFrsaB/Y 3v8SoQdSxcqEr5TX8f4Glk0ZZ4MYX0P2P4GjM73FF98tgWEnr0MVPVd1xVsKM0EQL8M1gc/YuRi 3g== X-Google-Smtp-Source: AGHT+IH3n/oS2ZwAsp2AIwG4hD/wbZJCbQ3lrXdWfI5/1KFRboUG9D9fXeWpZWbVwLwyRmNZLKtM1w== X-Received: by 2002:a05:6512:282b:b0:53d:a23d:37e6 with SMTP id 2adb3069b0e04-53dd3aadfecmr4227271e87.57.1732432663665; Sat, 23 Nov 2024 23:17:43 -0800 (PST) Original-Received: from trevarch (109-252-36-249.nat.spd-mgts.ru. [109.252.36.249]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dd2497f04sm1205001e87.254.2024.11.23.23.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2024 23:17:42 -0800 (PST) In-Reply-To: (Yuan Fu's message of "Sat, 23 Nov 2024 21:18:58 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295890 Archived-At: Yuan Fu writes: >> On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor wrote: >>=20 >> On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski wrote: >>>=20 >>> Trevor Arjeski tmarjeski@gmail.com writes: >>>=20 >>>=20 >>> I decided to hack around with this a little bit and found that adding >>> the following lines partially works: >>>=20 >>>=20 >>> I'm sure there is an issue with solving it this way, I just need someone >>> else more experienced to confirm. It is finicky where it turns the >>> highlighting on and off when you make some code changes, for example >>> adding and removing the semi-colon after the macro invocation. >>=20 >> Yuan would be the best to answer that. > > Using injection (what Emacs calls local parser, same thing) here is fine,= I > think. As Randy said, tree-sitter doesn=E2=80=99t have a good answer for = macros. If nvim > uses this workaround (create an injection for the macro and parses it like > normal rust code), then it should be fine for us to follow suit. > Any ideas why my crude implementation of the injection "flickers" on and off after certain changes? Thanks, Trevor