From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode Date: Sat, 30 Nov 2024 07:37:27 +0100 Message-ID: <87bjxxw7ko.fsf@daniel-mendler.de> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38789"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier To: 74615@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 30 07:38:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHH7f-0009yy-7Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Nov 2024 07:38:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHH7R-0006xP-86; Sat, 30 Nov 2024 01:38:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHH7E-0006wz-Ck for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 01:38:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHH7E-0001aN-14 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 01:38:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=zVaCv/6dNeuGI72W+UJDy1XJTQI4aurT+3AIh1NhRWY=; b=c90d/ED590LAF/pewUZx0Tav3AvVNGf516atgWJTwWqKAkEP1G+fbLG7m38qjDsyhIbDn+DBWx6Jd3creONMTx5wFcfNUnEw3PzX6MpybUgTFMVhqCvji4llYnLDMlYJqdN8HMmZ/wSc4VYf2emH5PKIBGhlaDkdUpFy4Km2EVsgMlxY7M/NrMsC2wrLyh/XjTqXhsrGAiHlRMx0v19zra7Ox1QlsTYlxsqyQylfiKBfmWttZ3+Sain2lE34y9J1s++cFVfUTGoMlSposrLcopss8pgr5bsjWx35geBeXlQMb6yr9mDwU6KoApjLR22XMJeIETt+FrdGQYTKtNozUQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHH7C-0004x8-G8; Sat, 30 Nov 2024 01:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2024 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74615 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.173294865718986 (code B ref -1); Sat, 30 Nov 2024 06:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Nov 2024 06:37:37 +0000 Original-Received: from localhost ([127.0.0.1]:45174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHH6n-0004wA-DZ for submit@debbugs.gnu.org; Sat, 30 Nov 2024 01:37:37 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHH6k-0004w2-P3 for submit@debbugs.gnu.org; Sat, 30 Nov 2024 01:37:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHH6k-0006ut-3z for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 01:37:34 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHH6i-0001OP-96 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 01:37:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zVaCv/6dNeuGI72W+UJDy1XJTQI4aurT+3AIh1NhRWY=; b=U91ujnQ2U2m0Bx7bGMx14hv22C iWKc6/jY6zAzXdbY2O+9gY7Owat0zAytP9tgW8sAU2H9UaBzExB4nyaz1aeES8+8VWF9t7O+foxOS qepsx+0wcQzzVcMVqrL7Sox/QG1HyjzpIFvL+yHQOmk6fSyatwlmeJmj3uKvzF/l7hxc=; Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296110 Archived-At: --=-=-= Content-Type: text/plain js-find-symbol/js--read-symbol reads a symbol via ido-completing-read and automatically activates ido-mode. For users of other completion systems (default completion, Icomplete/Fido, Vertico, Helm, ...) this is not desired. Icomplete/Fido/Vertico/etc. replace Ido and provide similar behavior for general completing-read. Patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-progmodes-js-Use-completing-read-instead-of-ido-comp.patch >From 3b4ccb677a16fc4934d62fed7e1f01b52399e633 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Wed, 1 Mar 2023 19:27:38 +0100 Subject: [PATCH] progmodes/js: Use completing-read instead of ido-completing-read --- lisp/progmodes/js.el | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index f74b8ab1c46..29566d38109 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -58,11 +58,8 @@ (eval-when-compile (require 'cl-lib) - (require 'ido) (require 'rx)) -(defvar ido-cur-list) -(declare-function ido-mode "ido" (&optional arg)) (declare-function treesit-parser-create "treesit.c") (declare-function treesit-induce-sparse-tree "treesit.c") (declare-function treesit-search-subtree "treesit.c") @@ -3288,11 +3285,7 @@ js--read-symbol initial input INITIAL-INPUT. Return a cons of (SYMBOL-NAME . LOCATION), where SYMBOL-NAME is a string and LOCATION is a marker." - (unless ido-mode - (ido-mode 1) - (ido-mode -1)) - - (let ((choice (ido-completing-read + (let ((choice (completing-read prompt (cl-loop for key being the hash-keys of symbols-table collect key) -- 2.45.2 --=-=-=--